Skip to content

Add 分身 pet by Julian - #21

Open
Gensun wants to merge 1 commit into
legeling:mainfrom
Gensun:pet/fenshen--julian
Open

Add 分身 pet by Julian#21
Gensun wants to merge 1 commit into
legeling:mainfrom
Gensun:pet/fenshen--julian

Conversation

@Gensun

@Gensun Gensun commented Jul 15, 2026

Copy link
Copy Markdown

Summary

  • add the original human-avatar pet 分身 by Julian
  • package it as a v2 8 × 11 spritesheet (1536 × 2288) with all 16 clockwise look directions
  • include only submission.json, pet.json, and spritesheet.webp
  • license the pet asset under CC BY 4.0 with adaptation and redistribution permission confirmed by the author

Validation

  • npm run previews
  • npm run readmes
  • npm run validate
  • npm run lint
  • npm run validate:pr
  • npm run install:pet -- fenshen--julian --codex-home <temporary-test-home>
  • v2 atlas geometry, transparency, chroma cleanup, standard animations, and all 16 look directions reviewed

Generated README, catalog, preview, QA, reference, and temporary files are intentionally excluded from this contributor PR.

Summary by CodeRabbit

  • 新功能
    • 新增“分身”宠物/角色及其完整元数据,包括名称、描述、类型和精灵图资源。
    • 提供预览图片、资源清单及安装所需文件映射。
    • 补充分类标签、授权信息和资源校验值,便于准确识别与管理。

@qodo-code-review

qodo-code-review Bot commented Jul 15, 2026

Copy link
Copy Markdown

Code Review by Qodo

Grey Divider

Sorry, something went wrong

We weren't able to complete the code review on our side. Please try again

Grey Divider

Qodo Logo

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 24eabdfc-25df-4adf-ae18-0feb2cca66ef

📥 Commits

Reviewing files that changed from the base of the PR and between c20f42f and be5f234.

📒 Files selected for processing (3)
  • pets/fenshen--julian/pet.json
  • pets/fenshen--julian/spritesheet.webp
  • pets/fenshen--julian/submission.json

📝 Walkthrough

Walkthrough

新增“分身”宠物条目的角色元数据与提交元数据,包含资源路径、预览资产、安装文件映射及 spritesheet 校验值。

Changes

分身宠物条目

Layer / File(s) Summary
宠物元数据与安装清单
pets/fenshen--julian/pet.json, pets/fenshen--julian/submission.json
新增角色标识、中文名称、描述、类型、精灵资源版本与路径,并补充 slug、分类、标签、授权、预览资源、Codex 安装映射和 SHA-256 校验字段。

Estimated code review effort: 1 (Trivial) | ~5 minutes

Poem

我是小兔,蹦进新家园,
分身元数据排成行。
精灵资源有路径,
安装清单闪亮亮。
校验值守护文件,
欢迎新伙伴登场!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 标题简洁且准确概括了本次新增 Julian 的“分身”宠物资源。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Add “分身” (fenshen--julian) v2 human-avatar pet submission

✨ Enhancement 🕐 Less than 10 minutes

Grey Divider

AI Description

• Add new v2 pet metadata for “分身” (Julian) and wire it into codex install.
• Declare CC BY 4.0 licensing and provenance/rights confirmation in submission metadata.
• Provide preview/asset pointers and a spritesheet integrity hash for validation.
Diagram

graph TD
  Pkg["pets/fenshen--julian/"] --> Sub["submission.json"] --> Val(["validate:pr / tooling"]) --> Cat(["Catalog / QA outputs"])
  Pkg --> Pet["pet.json"] --> Inst(["install:pet (codex)"]) --> Rend(["Pet renderer"])
  Pkg --> Sheet["spritesheet.webp"] --> Rend
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Include generated previews/readmes/catalog artifacts in the PR
  • ➕ Reviewers can visually verify animations/directions without running scripts
  • ➕ Reduces ambiguity around preview paths and expected outputs
  • ➖ Adds noisy, frequently-regenerated files to contributor PRs
  • ➖ Increases merge conflicts and repo churn from generated assets
2. Use PNG atlas instead of WebP spritesheet
  • ➕ Potentially simpler toolchain compatibility in some environments
  • ➕ Easier manual inspection with basic image tools
  • ➖ Larger repo footprint and slower downloads
  • ➖ WebP is typically preferred for size/performance in asset packs

Recommendation: Keep the PR’s current approach: commit only source-of-truth submission metadata and the referenced spritesheet, and rely on repo tooling to generate previews/readmes/catalog artifacts. This keeps contributor PRs small and reviewable while still enabling deterministic regeneration and validation via the provided preview pointers and spritesheet sha256.

Files changed (2) +35 / -0

Enhancement (2) +35 / -0
pet.jsonDefine the “分身” pet runtime metadata (v2 spritesheet) +8/-0

Define the “分身” pet runtime metadata (v2 spritesheet)

• Adds the pet definition with id, localized display name, and description. Marks the asset as sprite v2 and points runtime loading to spritesheet.webp, classifying it as a person-kind pet.

pets/fenshen--julian/pet.json

submission.jsonAdd submission metadata: provenance, CC BY 4.0 license, previews, and sha256 +27/-0

Add submission metadata: provenance, CC BY 4.0 license, previews, and sha256

• Introduces the submission record including canonical key, categorization/tags, and explicit CC BY 4.0 licensing with rights confirmation note. Declares codex install mappings, preview asset locations, and a spritesheet sha256 for integrity validation.

pets/fenshen--julian/submission.json

ⓘ You are approaching your monthly quota for Qodo. Upgrade your plan

This was referenced Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant