Skip to content

Fix JesseTheFox idle blink and animation transparency - #59

Merged
legeling merged 3 commits into
legeling:mainfrom
ITJesse:submit/jesse-the-fox--itjesse-v2
Jul 27, 2026
Merged

Fix JesseTheFox idle blink and animation transparency#59
legeling merged 3 commits into
legeling:mainfrom
ITJesse:submit/jesse-the-fox--itjesse-v2

Conversation

@ITJesse

@ITJesse ITJesse commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Follow-up animation repair for the JesseTheFox / 阿博 V2 pet merged in [Pet] Add JesseTheFox (阿博) V2 #52.
  • Restore a short closed-eye blink while retaining the approved RPG-style breathing loop.
  • Remove cyan/blue chroma-key residue from the laptop working/executing frames and idle outline without deleting the shorts' real blue-gray colors.
  • Realign waving with the current idle body so action transitions keep the same head, collar, belt, pelvis, and planted-foot anchors.
  • This PR changes only spritesheet.webp and its SHA-256 in submission.json; pet.json and metadata remain unchanged.

Visual evidence

JesseTheFox V2 contact sheet

The contact sheet is hosted from a separate preview-only branch in the submitter's fork and is not part of this PR diff. CI may also generate a downloadable preview artifact.

Review notes

  • Idle sequence: 0 → 1 → 2 → 2 → 1 → 0 px breathing rise, with a 140 ms closed-eye blink in frame 5.
  • Belt, hips, legs, planted feet, and tail root remain fixed across the idle loop.
  • Working/executing keeps the approved laptop pose and gaze toward the screen; only cyan-key edge residue was removed.
  • Waving uses the current idle body as its static reference: all four frames keep foot baseline y=202, pelvis bounds y=122–160, and chest bottom y=117; only the left arm performs the wave.
  • Duplicate status is unchanged from [Pet] Add JesseTheFox (阿博) V2 #52: canonical key original/itjesse/jesse-the-fox identifies the already-listed pet; this is an in-place asset fix, not a second listing.

Authorship and source

  • Final pet asset author/adaptor: Jesse Zhu (@ITJesse).
  • Source: Jesse Zhu's own original character design and private character reference sheets. The final atlas was independently AI-generated with AI assistance, then directed, adapted, and repaired by Jesse Zhu.
  • Public source_url remains intentionally empty because the source material is private and original.
  • Usage remains Non-commercial use only.

Verification

  • Runtime: V2, spriteVersionNumber: 2, atlas 1536×2288.
  • Checkerboard, dark, and light background review completed for the repaired rows.
  • V2 atlas validator: passed with zero transparent-RGB residue, no errors, and no warnings.
  • Spritesheet SHA-256: e61db90a40cf7c7dca50eaaf08a9094e850d6d0e379160f5a320b921e0f67522.
  • npm run validate:pr: passed in an isolated single-pet harness.
  • npm run lint: passed.
  • Independent install: passed; installed spritesheet matched byte-for-byte.

Summary by CodeRabbit

  • 修复
    • 更新 Jesse the Fox 精灵图资源的校验信息,确保资源验证结果与当前内容一致。

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

更新 Jesse 狐狸 submission.json 中的 spritesheet_sha256 值,以匹配新的 spritesheet 资源内容。

Changes

精灵图资源校验

Layer / File(s) Summary
更新精灵图校验值
pets/jesse-the-fox--itjesse/submission.json
spritesheet_sha256 更新为新的 SHA-256 哈希值。

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Poem

小兔蹦跳看哈希,
狐狸精灵换新衣。
校验值已稳稳落,
资源内容不迷离。

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 标题准确概括了这次对 JesseTheFox 动画眨眼与透明度问题的修复。
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@pets/jesse-the-fox--itjesse/submission.json`:
- Line 38: Update the spritesheet_sha256 field in submission.json to the SHA-256
computed from the actual spritesheet.webp content, using
017e9c06f2bf0f16eedcb1e6507431c53a07537759e091a3d38100e76eb2adaa as the expected
value.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d95b0257-121c-4e19-adc3-a04e981fe41c

📥 Commits

Reviewing files that changed from the base of the PR and between bf7d873 and 9ae165a.

📒 Files selected for processing (2)
  • pets/jesse-the-fox--itjesse/spritesheet.webp
  • pets/jesse-the-fox--itjesse/submission.json
👮 Files not reviewed due to content moderation or server errors (1)
  • pets/jesse-the-fox--itjesse/spritesheet.webp

Comment thread pets/jesse-the-fox--itjesse/submission.json
@legeling
legeling merged commit 74fad0c into legeling:main Jul 27, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants