fix: resolve issues #499 #500 #501 #502 - #573
Merged
legend-esc merged 2 commits intoJul 25, 2026
Merged
Conversation
…nd-esc#502 legend-esc#499 — Add THROTTLER_SKIP_IPS env var (comma-separated CIDR list) to ThrottlerGuard. Requests from matched IPs bypass throttling silently (no bypass headers). Includes parseCidr/isInSkipList helpers and 6 new test cases in throttler.guard.spec.ts. .env.example updated. legend-esc#500 — Expand AdminComponent with methodology registration form, required-approvals slider (1–N), and contract pause/unpause section with confirmation modal. AdminService/Controller now expose: POST /admin/methodologies GET /admin/nonce/:address POST /admin/required-approvals app.routes.ts /admin route now uses AdminComponent. api.service.ts updated with corresponding Angular methods. admin.component.spec.ts and updated admin.controller/service specs added. legend-esc#501 — Retire certificate endpoint refactored to use StreamableFile instead of @res() so NestJS interceptors remain active. Route renamed to GET /retirement/:id/certificate. Rate limit applied via Throttle({ limit: 10, ttl: 60_000 }). Spec verifies StreamableFile type, content-type, content-disposition, NotFoundException, and absence of @res() parameter. legend-esc#502 — OracleError codes renumbered from overlapping 119–129 range to canonical 400–410 range in contracts/mrv_oracle/src/lib.rs. oracle.service.ts gains mapOracleContractError() mapping codes 400–410 to HTTP exceptions. ERROR_CODES_REFERENCE.md created with full error table for all four contracts and migration notes. chore — .gitignore pattern updated from test_snapshots/ to **/test_snapshots/ (covers all depths). All tracked Soroban test snapshot JSON files removed from the index (files remain on disk).
|
@Chuks-coderr Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#499 — Add THROTTLER_SKIP_IPS env var (comma-separated CIDR list) to ThrottlerGuard. Requests from matched IPs bypass throttling silently (no bypass headers). Includes parseCidr/isInSkipList helpers and 6 new test cases in throttler.guard.spec.ts. .env.example updated.
#500 — Expand AdminComponent with methodology registration form, required-approvals slider (1–N), and contract pause/unpause section with confirmation modal. AdminService/Controller now expose:
POST /admin/methodologies
GET /admin/nonce/:address
POST /admin/required-approvals
app.routes.ts /admin route now uses AdminComponent. api.service.ts updated with corresponding Angular methods. admin.component.spec.ts and updated admin.controller/service specs added.
#501 — Retire certificate endpoint refactored to use StreamableFile instead of @res() so NestJS interceptors remain active. Route renamed to GET /retirement/:id/certificate. Rate limit applied via Throttle({ limit: 10, ttl: 60_000 }). Spec verifies StreamableFile type, content-type, content-disposition, NotFoundException, and absence of @res() parameter.
#502 — OracleError codes renumbered from overlapping 119–129 range to canonical 400–410 range in contracts/mrv_oracle/src/lib.rs. oracle.service.ts gains mapOracleContractError() mapping codes 400–410 to HTTP exceptions. ERROR_CODES_REFERENCE.md created with full error table for all four contracts and migration notes.
chore — .gitignore pattern updated from test_snapshots/ to **/test_snapshots/ (covers all depths). All tracked Soroban test snapshot JSON files removed from the index (files remain on disk).
Summary
Changes
Layer(s) affected
Testing
cargo testpassesnpm run testpasses (api)npm run testpasses (frontend)Checklist
Breaking changes
closes
closes #499
closese #500
closes #501
closes #502