Devoclan/four fixes#581
Merged
Merged
Conversation
|
@devoclan Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #523
closes #524
closes #525
closes #526
Why this matters now: frontend/src/app/core/store/credit.store.ts uses signals, but stellar-wallet.service.ts uses BehaviorSubject. Components subscribed to the wallet service re-render on every value emission even if the value hasn't changed, causing jank in the UI.
Problem / What: StellarWalletService exports walletAddress$: BehaviorSubject. This should be a signal for consistency and better change detection.
Why this matters now: Production logs show P95 latency for GET /credits is 2 seconds, but there's no visibility into which query is slow. PostgreSQL query logs are not integrated into the application monitoring stack.
Problem / What: TypeORM has no query logging enabled in production. Slow queries (>500ms) should be logged with the full SQL, execution plan, and request ID.
Why this matters now: GET /api/v1/credits?owner=G... takes 1.5 seconds with 10K credits in the table because there's no index on owner. The migration adds indexes on status, vintage_year, but not owner.
Problem / What: api/src/migrations/1748390400000-AddCreditIndexes.ts creates indexes on filtering columns but not join/owner columns. CreditRepository.findByFilter with owner filter does a sequential scan.