Include extras in SSD config file creation#81
Draft
apearsonn wants to merge 3 commits intolegend-exp:mainfrom
Draft
Include extras in SSD config file creation#81apearsonn wants to merge 3 commits intolegend-exp:mainfrom
apearsonn wants to merge 3 commits intolegend-exp:mainfrom
Conversation
Contributor
|
I will have a look at this and see how it performs. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
==========================================
- Coverage 39.05% 38.71% -0.34%
==========================================
Files 27 27
Lines 1987 2025 +38
==========================================
+ Hits 776 784 +8
- Misses 1211 1241 +30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
@hervasa2, @fhagemann is this still of interest/relevant? |
Contributor
|
Yes it is. I can review it within the next couple months but if someone wants to step in sooned that would be great! |
Contributor
|
Ok, let's put it on the LEGEND Julia to-do list. :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjust configuration of config dictionaries to include detectors that have extras (top groove, bottom cylinder, crack).