Skip to content

Comments

Include extras in SSD config file creation#81

Draft
apearsonn wants to merge 3 commits intolegend-exp:mainfrom
apearsonn:dev
Draft

Include extras in SSD config file creation#81
apearsonn wants to merge 3 commits intolegend-exp:mainfrom
apearsonn:dev

Conversation

@apearsonn
Copy link
Contributor

Adjust configuration of config dictionaries to include detectors that have extras (top groove, bottom cylinder, crack).

@apearsonn apearsonn marked this pull request as draft December 3, 2024 16:21
@fhagemann fhagemann self-assigned this Dec 3, 2024
@fhagemann
Copy link
Contributor

I will have a look at this and see how it performs.
Let's also check if it can be merged without problems into #74.

@fhagemann fhagemann added the ssd Related to the SolidStateDetectors extension label Dec 3, 2024
@codecov
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

❌ Patch coverage is 39.28571% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.71%. Comparing base (8be1f46) to head (deffb1f).
⚠️ Report is 142 commits behind head on main.

Files with missing lines Patch % Lines
ext/LegendDataManagementSolidStateDetectorsExt.jl 39.28% 34 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
- Coverage   39.05%   38.71%   -0.34%     
==========================================
  Files          27       27              
  Lines        1987     2025      +38     
==========================================
+ Hits          776      784       +8     
- Misses       1211     1241      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oschulz
Copy link
Contributor

oschulz commented Jan 13, 2026

@hervasa2, @fhagemann is this still of interest/relevant?

@hervasa2
Copy link
Contributor

Yes it is. I can review it within the next couple months but if someone wants to step in sooned that would be great!

@oschulz
Copy link
Contributor

oschulz commented Jan 13, 2026

Ok, let's put it on the LEGEND Julia to-do list. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ssd Related to the SolidStateDetectors extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants