Add A/E resolution term from electronic noise

[tdixon97]

No description provided.

[codecov]

Codecov Report

❌ Patch coverage is 58.82353% with 42 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.26%. Comparing base (a8e6c1a) to head (fb3317c).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
...imflow/scripts/extract_hpge_current_pulse_model.py	0.00%	26 Missing ⚠️
workflow/src/legendsimflow/hpge_pars.py	78.94%	16 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
+ Coverage   63.05%   63.26%   +0.21%     
==========================================
  Files          19       19              
  Lines        1394     1481      +87     
==========================================
+ Hits          879      937      +58     
- Misses        515      544      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Copilot]

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (3)

workflow/src/legendsimflow/scripts/tier/evt.py:36

• The evt.py script is incomplete. It only creates an empty file using Path(evt_file).touch() but doesn't actually process the opt_file and hit_file inputs to generate proper evt tier data. The input files (opt_file and hit_file) are defined but never used. This suggests the implementation is not finished.
  workflow/src/legendsimflow/scripts/tier/evt.py:3
• Trailing comma after the author's name in the copyright line should be removed.
  workflow/src/legendsimflow/scripts/tier/evt.py:21
• Import of 'legenddataflowscripts' is not used.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[gipert]

This needs a rebase

[tdixon97]

Yes needs rebase but also there is some issue to debug (lots of nans)

[tdixon97]

actually ... seems the AI caught a bug that might be the issue

[tdixon97]

This is now working well, but we have to decide how to save the plots...

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 12 comments.

Comments suppressed due to low confidence (1)

workflow/src/legendsimflow/hpge_pars.py:536

• The df_cfg variable is assigned on lines 522-526 based on whether 'setups' exists in dataflow_config, but then it's immediately overwritten on line 536 with dataflow_config.paths. This makes the conditional assignment on lines 522-526 pointless. This appears to be dead code that should either be removed or the logic needs to be corrected to use the conditional df_cfg assignment consistently.

    df_cfg = (
        dataflow_config["setups"]["l200"]["paths"]
        if ("setups" in dataflow_config)
        else dataflow_config["paths"]
    )

    # get the reference cal run
    cal_runid = mutils.reference_cal_run(metadata, runid)
    _, period, run, _ = re.split(r"\W+", cal_runid)

    msg = f"inferred reference calibration run: {cal_runid}"
    log.debug(msg)

    # get the paths to hit and raw tier files
    df_cfg = dataflow_config.paths

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[gipert]

can you fix the docs?

[gipert]

why did you merge this if the CI is failing

[tdixon97]

Check the CI failure, its not our fault

[gipert]

it is, this is the error

https://app.readthedocs.org/projects/legend-simflow/builds/31294353/#305061620--44