Conversation
Member
gipert
commented
Feb 20, 2026
- chore: add debug logging for tcm progress in generate_tcm_cols
- perf: speed up last_instance in tcm by precomputing keys and vectorizing
Co-authored-by: aider (gpt-5.2) <aider@aider.chat>
Co-authored-by: aider (gpt-5.2) <aider@aider.chat>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #653 +/- ##
==========================================
+ Coverage 52.51% 52.56% +0.04%
==========================================
Files 60 60
Lines 8270 8274 +4
==========================================
+ Hits 4343 4349 +6
+ Misses 3927 3925 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR improves the performance and observability of TCM generation in pygama.evt, focusing on speeding up the “last instance” computation during coincidence clustering and adding debug-level progress logging.
Changes:
- Precompute and cache
table_keysmapping helpers to support faster per-iteration processing. - Vectorize “last occurrence per table_key” computation using NumPy (
searchsorted+maximum.at) instead of a per-hit Python loop. - Add debug logging summarizing TCM progress per iteration and remove some noisier debug statements.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.