Skip to content

Conversation

@ManuelHu
Copy link
Contributor

  • rename fccd param to fccd_in_mm
  • read ak array with units in the tutorial and make units a bit more explicit.
  • we should iterate a bit on the docs and how to "mark" unit-aware parameters. I got some questions from users because of the lack of docs on this topic.

some other things I found:

  • HITS.__edep should not work since a long time ago (did it ever work?), that should now only be HITS.edep in a config file.

@ManuelHu ManuelHu requested a review from tdixon97 January 24, 2026 16:24
@tdixon97
Copy link
Collaborator

tdixon97 commented Jan 24, 2026

I think it looks good, I agree with you we have a bit more work still to do on unit handling.

I think we should gradually phase out the config files approach which is a bit hard to maintain / test. But I still think we need to provide some "ready to use" post-processing options to not require everyone to write their own scripts.

@codecov
Copy link

codecov bot commented Jan 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.04%. Comparing base (d31e919) to head (7a4f723).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #154   +/-   ##
=======================================
  Coverage   70.04%   70.04%           
=======================================
  Files          33       33           
  Lines        2597     2597           
=======================================
  Hits         1819     1819           
  Misses        778      778           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ManuelHu ManuelHu marked this pull request as ready for review January 25, 2026 12:22
@ManuelHu ManuelHu merged commit eab7e81 into main Jan 25, 2026
15 checks passed
@ManuelHu ManuelHu deleted the docs-units branch January 25, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants