-
Notifications
You must be signed in to change notification settings - Fork 12
add stacking scheme for bulk electron tracks #477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Wow, nice work Manuel! I think this will have a huge impact on many simulations... not just optics but eg. radiogenic sims of far sources (cryostat?) |
70aa66c to
2a87a5b
Compare
|
the following macro is helful for testing: however, the code does not yet work. Apparently, |
2a87a5b to
b2b8027
Compare
|
I just wanted to ask if you can not just use |
|
I did some tests and did not observe a significant speed-up. If we do not stack some e- tracks, for example they are within safety what happens to the optical tracks produced by the e-s, does the usual optical stacking apply? |
|
If I did not introduce any error in the logic, we should still have a two-stage stack in the end (there is actually no way to stack into higher stages in a sane modular way... This really is a state machine in the end.)
The important option is |
b2b8027 to
552ac80
Compare
552ac80 to
680e0dd
Compare
680e0dd to
bf7a09e
Compare
187a61e to
96d06f9
Compare
|
I might revisit this sometime when i have time (certainly not before the collab meeting) But i have written my own StackingFilter for cosmogenics putting electrons/positrons in the water tank on the stack and then only simulating them once Ge77 was produced and i experience a speed-up of a factor of ~10 for cosmogenic simulations. It is important to note that i did not just blindly put any electron/positron on the stack, as that would mess up electromagnetic showers. https://github.com/EricMEsch/recosm/blob/master/simulations/ge77_muons/src/CustomStackingFilter.cc But i also did not use any safety and distance computation. |
yes, and that might be the difference... Moritz did some (quite some extensive) tests in #476 and found a speed-up without safety calculation, and a slow-down with it enabled.... |
for now, this is just meant as a reference for (manual) testing