physics list fixes #582
Draft
physics list fixes #582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think we should try to have a decent validation suite before starting to change physics...? |
Contributor
Author
|
yes. I want to use this PR/branch mostly for checking if this has an impact. This change (+ the ones I still need to push) just align it with the upstream optical physics constructor, btw: |
ManuelHu
force-pushed
the
physics
branch
2 times, most recently
from
a36e97f to
0a3187a
Compare
ManuelHu
force-pushed
the
physics
branch
2 times, most recently
from
78fd85e to
7ec70db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
very much WIP for testing