Support direct class passing #145
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support direct class passing for policy/algorithm
* feat(runner): support direct class passing for policy/algorithm
Add _resolve_class() helper to OnPolicyRunner that resolves class_name
from multiple formats:
- Direct class objects (type) - enables passing custom classes directly
- Simple names ("ActorCritic") - existing eval behavior preserved
- Qualified names ("module:Class" or "module.Class") - uses importlib
This enables downstream projects to define custom actor-critic models
without modifying rsl_rl. Fully backwards-compatible.
Example usage:
from my_project.models import MyPolicy
runner_cfg["policy"]["class_name"] = MyPolicy # Pass class directly
* Refactor class resolution into generalized resolve_callable utility
Address PR feedback from @cschwarke:
- Move _resolve_class from OnPolicyRunner to utils.py as resolve_callable
- Support nested attributes (e.g., "module:Outer.Inner", "module.Outer.Inner")
- Generalize to replace string_to_callable (now deprecated)
- Look up simple names like "PPO" in rsl_rl.algorithms/modules
- Add comprehensive test suite (23 tests)
Supported formats:
- Direct callable: pass class/function directly
- Colon format: "module.path:Attr.Nested" (explicit, recommended)
- Dot format: "module.path.ClassName" (progressive module splitting)
- Simple name: "PPO", "ActorCritic" (rsl_rl package lookup)
* Merge origin/main-rsl into feature/direct-class-passing
Resolve conflicts to integrate main-rsl updates with resolve_callable feature.
* fix tests, add to distillation runner, remove string_to_callable
Approved-by: Clemens Schwarke
ClemensSchwarke
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to pass custom modules and functions without having to modify the library. This adresses #135