fix: preload cancel actually cancels image loads (v0.2.3.3)#7
Open
lemonicefate wants to merge 1 commit intomainfrom
Open
fix: preload cancel actually cancels image loads (v0.2.3.3)#7lemonicefate wants to merge 1 commit intomainfrom
lemonicefate wants to merge 1 commit intomainfrom
Conversation
state.preloadAbort (AbortController) was dead code — new Image() cannot subscribe to AbortSignal, so cancelPreload() was a silent no-op. Rapid procedure switches kept zombie image loads consuming bandwidth. Replace with state.preloadImages array; cancelPreload() sets img.src='' on each tracked Image (telling the browser to stop loading) then clears the array. One unit test added to cover the cancellation behaviour. https://claude.ai/code/session_01E7NL3UfbiRzDWcxQYpGDub
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
state.preloadAbort(AbortController) was dead code —new Image()cannot subscribe to an AbortSignal, socancelPreload()was a silent no-op. Rapid procedure switches kept zombie image loads consuming bandwidth.state.preloadAbortwithstate.preloadImages: [];cancelPreload()now setsimg.src = ''on each tracked Image (telling the browser to abort the load) and clears the array.cancelPreload()zeros everyimg.srcand empties the array.Test plan
npm test— 43/43 passing (42 pre-existing + 1 newcancelPreloadtest)[0.2.3.3] - 2026-05-08https://claude.ai/code/session_01E7NL3UfbiRzDWcxQYpGDub
Generated by Claude Code