Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flexible Torch matrix factorizer #668

Merged
merged 34 commits into from
Mar 20, 2025

Conversation

mdekstrand
Copy link
Member

@mdekstrand mdekstrand commented Mar 18, 2025

This is the long-awaited change to bring a flexible PyTorch matrix factorization implementation to LensKit (#203).

@mdekstrand mdekstrand added the components LensKit recommendation components label Mar 18, 2025
@mdekstrand mdekstrand self-assigned this Mar 18, 2025
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 97.82609% with 8 lines in your changes missing coverage. Please review.

Project coverage is 91.03%. Comparing base (b7b5b03) to head (1e2e5f4).
Report is 35 commits behind head on main.

Files with missing lines Patch % Lines
src/lenskit/flexmf/_model.py 92.30% 4 Missing ⚠️
src/lenskit/data/relationships.py 33.33% 2 Missing ⚠️
src/lenskit/flexmf/_base.py 98.11% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #668      +/-   ##
==========================================
+ Coverage   90.58%   91.03%   +0.45%     
==========================================
  Files         126      132       +6     
  Lines        8717     9078     +361     
==========================================
+ Hits         7896     8264     +368     
+ Misses        821      814       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mdekstrand mdekstrand marked this pull request as ready for review March 20, 2025 21:21
@mdekstrand mdekstrand merged commit f877fd3 into lenskit:main Mar 20, 2025
33 checks passed
@mdekstrand mdekstrand deleted the feature/flexmf branch March 20, 2025 21:46
@mdekstrand mdekstrand added this to the 2025.3 milestone Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
components LensKit recommendation components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant