Skip to content

Make dependencies optional #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make dependencies optional #44

wants to merge 2 commits into from

Conversation

cdonovick
Copy link
Collaborator

No description provided.

@cdonovick
Copy link
Collaborator Author

resolves #37

@cdonovick cdonovick requested a review from leonardt June 1, 2019 17:02
leonardt
leonardt approved these changes Jun 1, 2019
View reviewed changes
Copy link
Owner

@leonardt leonardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I assume we need to update downstream tools that require FP/SMT need to update their flows to install the extras? I'm thinking peak, lassen, metamapper, garnet. Any others?

.travis.yml
- pip install -r requirements.txt
- pip install pytest-cov
- pip install -e .
- pip install -e .[TEST]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@cdonovick
Copy link
Collaborator Author

cdonovick commented Jun 1, 2019 •
edited
Loading

@leonardt
Yes, you are correct we will need to update downstreams tools.
I am aware of the following dependencies:
Lassen - hwtypes[FP]
Peak - hwtypes[SMT]
Fault - hwtypes[Z3] (for constrained random)

@Kuree
Copy link

Kuree commented Jun 1, 2019

Is there any way to install all in a single command as in
pip install git+https://github.com/leonardt/hwtypes@HASH#egg=hwtypes? GarnetFlow uses this pip command to install packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardt leonardt leonardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdonovick @Kuree @leonardt