279 clarify auto adapt

[olivierilbert]

• Remove a1 and shift1 which were useless
• Apply shift0 when preparing the catalogue. So, shifts0 are always applied when APPLY_SYSSHIFT defined.
• a0 will be computed when AUTO_ADAPT YES, even if APPLY_SYSSHIFT exist. I tested that a0 are always lower than 0.01 when I applied previously computed offsets with APPLY_SYSSHIFT, which is a nice consistency check.

[codecov]

Codecov Report

Attention: Patch coverage is 87.50000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 65.68%. Comparing base (30913b9) to head (9644cad).
Report is 15 commits behind head on main.

Files with missing lines	Patch %	Lines
src/lib/zphota.cpp	0.00%	4 Missing ⚠️
src/lib/photoz_lib.cpp	81.81%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #280      +/-   ##
==========================================
+ Coverage   58.95%   65.68%   +6.73%     
==========================================
  Files          50       50              
  Lines        6478     6458      -20     
  Branches      946      944       -2     
==========================================
+ Hits         3819     4242     +423     
+ Misses       2659     2216     -443     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[raphaelshirley]

Looks good to me. I suggest merging the other minor changes to process in PR #278 after this is merged and then making a complementary PR in rail_lephare to propagate it after publishing a new version.

[raphaelshirley]

I think I have process at 100% now and have removed the offsets from the process parameters.

[raphaelshirley]

I had also forgotton that I implemented this function which allows the user to use absolute paths to "load" a sed list:

lephare/src/lephare/process.py

Line 241 in f5b5b57

def load_sed_list(path_to_list, object_type, absolute_paths=False):

which may be relevant re the absolute path discussion

[johannct]

Let's add the abs path code for a dedicated quick issue/branch, unless the unit tests for it are ready.
Otherwise, it is all good to go I think

[raphaelshirley]

The load_sed_list is already implemented and tested. I think we may have implemented partly with sharing between bpz and lephare in mind.

[raphaelshirley]

@olivierilbert Are we good to go?