Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance DataGrid UI and Fix Style Issues #1192

Merged
merged 7 commits into from
Feb 1, 2025

Conversation

stepwise-alan
Copy link
Contributor

@stepwise-alan stepwise-alan commented Aug 8, 2024

Pull request type

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

Issue Number: #410, #1160, #977, #256

What is the new behavior?

  • Fixed issues with DataGrid row highlighting on selection and hover.
  • Added sort icons to DataGrid headers.
  • Corrected the appearance of DataGridComboBoxColumn in dark mode.
  • Improved the overall UI of DataGrid for a more polished and modern look.

Other information

image
image
image
image

@github-actions github-actions bot added controls Changes to the appearance or logic of custom controls. PR Pull request gallery WPF UI Gallery dotnet release labels Aug 8, 2024
@github-actions github-actions bot added the styles Topic is related to styles label Aug 13, 2024
@stepwise-alan stepwise-alan marked this pull request as ready for review August 13, 2024 01:34
@MeltyObserver
Copy link

can a maintainer review this already? it's been 3 months...

@github-actions github-actions bot added the ⭐ top pull request Top pull request. label Dec 7, 2024
@github-actions github-actions bot mentioned this pull request Dec 7, 2024
@APerricone
Copy link

We need this, can a maintainer unblock it?

@pomianowski pomianowski merged commit 89fda9c into lepoco:main Feb 1, 2025
2 checks passed
pomianowski added a commit that referenced this pull request Feb 1, 2025
* fix: Add styles for DataGrid textbox columns

* Update DataGrid styles

* Remove deprecated color definitions and update styles

* Update TextColumnElementStyle to use TextBlock instead of TextBox

---------

Co-authored-by: pomian <[email protected]>
@LucaSamarCMA
Copy link

Is there a way to use the old style? I’d like to use this new release, but it has broken my UI

@chucker
Copy link
Collaborator

chucker commented Feb 6, 2025

Is there a way to use the old style? I’d like to use this new release, but it has broken my UI

You should be able to take the old XAML version, give that style a name, and specify that in your grid.

@APerricone
Copy link

I see, this release still have a lot of issues, and there are new: now the grid is all transparent... why? and still ignore RowBackground and AlternatingRowBackground... now I had to add Background="#FFF" to have it white.

@chucker
Copy link
Collaborator

chucker commented Feb 16, 2025

I see, this release still have a lot of issues, and there are new: now the grid is all transparent... why? and still ignore RowBackground and AlternatingRowBackground... now I had to add Background="#FFF" to have it white.

I've made a PR over at #1350. The following now works:

            <ui:DataGrid
                Height="400"
                AlternatingRowBackground="#eeeeee"
                ItemsSource="{Binding ViewModel.ProductsCollection, Mode=TwoWay}"
                RowBackground="#dddddd" />
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controls Changes to the appearance or logic of custom controls. dotnet gallery WPF UI Gallery PR Pull request release ⭐ top pull request Top pull request. styles Topic is related to styles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants