Java06. ДЗ 01, Горячева Валерия #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sproshev
approved these changes
Oct 28, 2018
| return emptyLogResult(); | ||
| } | ||
| history.stream().filter( | ||
| new Predicate<CommitInfo>() { |
There was a problem hiding this comment.
предикат не понял
если указана ревизия, то все коммиты-наследники должны быть пропущены, разве это гарантируется commitInfo.hash.startsWith(revision)? по текущему вычислению hash -- не похоже
Owner
Author
There was a problem hiding this comment.
@sproshev исправила все замечания в третьей части
|
|
||
| public class Message { | ||
|
|
||
| private ByteArrayOutputStream os; |
There was a problem hiding this comment.
можно было StringBuilder заиспользовать
| public String time; | ||
| public String hash; | ||
| public String message; | ||
| public String branch; |
There was a problem hiding this comment.
лучше стараться делать объекты immutable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.