fix: resolve HDFCAMC logic, past ex-dates flag, and Basis Watch corp action visibility#145
Conversation
…action visibility
This commit fixes the following issues:
1. Fixes the Basis Watch Corporate Actions column being empty by correcting the property access (`d.futures.ca` to `f.ca`).
2. Fixes the `is_above_2_percent` (extra-ordinary) fallback logic so that when no time is provided, it defaults to `<= ref_date` rather than `< ref_date`. This uses the same day's close instead of strictly the previous day's close.
3. Fixes the forecast display so that forecasted dividends >2% show a warning note ("check for extra-ordinary") instead of definitively setting the "extra ordinary" flag, since they haven't happened yet.
4. Fixes the extra-ordinary logic so past ex-dates do not set the main display's "Is above 2%" flag to Yes.
5. Enlarges the manual edit asterisk `*` in the UI to make it more visible.
Co-authored-by: letssayx <[email protected]>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…ns dividend rules - Adjusted derivative routes logic to map corporate actions properly into Basis Watch per user specs, specifically handling board meetings and events without ex-dates. - Updated special sit routes to properly calculate the 2% extra-ordinary dividend logic using the previous day's close price when the exact time is unknown, resolving false positives on HDFCAMC. - Improved the UI for manual edits by making the `*` asterisk larger and ensuring it disappears properly if the user reverts to the system value. - Reverted the unintended Alembic migration modifications and removed debug scripts from previous iterations. Co-authored-by: letssayx <[email protected]>
letssayx
deleted the branch
fix/corporate-action-display-and-logic-1305789934504582244
1 participant
Resolves user feedback regarding the Special Sit >2% math, Basis Watch column display, and manual edit asterisk size.
PR created automatically by Jules for task 15327847643741507950 started by @letssayx