Fix Dividends Data Bank Timeline Sync#149
Open
letssayx wants to merge 4 commits into
Open
Conversation
…traction - Broadened backend queries in `special_sit_routes.py` to include AGMs and postponed/rescheduled meetings. - Updated `workbench.html` deduplication logic to ensure rescheduled meetings (like BPCL) render as a proper timeline. - Added extraction of exact broadcast time to board meeting dates in the UI for precise evaluation. Co-authored-by: letssayx <[email protected]>
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Adjust `workbench.html` to separate `isPotentialMatch` from `isDividendRelated`. - Only create synthetic rows for genuine dividend-related board meetings, preventing "financial result" intimations from cluttering the UI or hiding genuine dividends like BHEL's. - Keep the `diffDays === 0` strict deduplication to allow BPCL's rescheduled timeline (12th and 19th) to show up. - Fix backend fetching to allow broad categories for timeline linkage without creating fake upcoming events. - Append exact broadcast times to meeting dates as requested for extra-ordinary evaluations. Co-authored-by: letssayx <[email protected]>
- Updates frontend deduplication to use exact calendar day matching to prevent rescheduled meetings (like BPCL) from being hidden. - Improves Board Meeting and Broadcast Time extraction to prevent timezone shifting and display exact time alongside dates. - Adds robust case-insensitive parsing to capture and tag AGMs correctly in the UI. - Implements strict is_valid_standalone checks in Special Situations backend to prevent historical generic 'Financial Results' meetings from polluting the timeline, while preserving upcoming intimations. Co-authored-by: letssayx <[email protected]>
- Updated frontend deduplication logic to merge rescheduled board meetings effectively using a <= 60 day rolling window for identical dividend types - Expanded the match window between intimations and official corporate actions to [-10, 180] days to fix missing lifecycle events - Extracted and rendered both precise AGM dates and exact board meeting local times cleanly within the UI tables - Cleaned up backend queries to prevent generic missing amount announcements from clogging the Historical UI timeline - Ensured long-dated cyclical records like BHEL are properly clustered and single-row aggregated Co-authored-by: letssayx <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves missing dividends, rescheduled meetings, and AGM intimation captures in the Dividends Data Bank UI by properly fetching, formatting, and rendering timeline data.
PR created automatically by Jules for task 8798568501844201849 started by @letssayx