Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A set of powerline-related fixes #37

Merged
merged 5 commits into from
Jun 3, 2015
Merged

Conversation

ZyX-I
Copy link
Collaborator

@ZyX-I ZyX-I commented May 29, 2015

Most notable is libvterm in dev-libs (maybe it makes sense to remove this package completely, though upstream does not do tests). I hope that presence of libvterm-neovim in dev-libs in main portage tree puts an end to the discussion “what category this package should belong to”.

libvterm-neovim mainly exists because you cannot disable stderr warning or debug messages in upstream libvterm and is rather compatible. Also contains some minor fixes AFAIK.

@leycec
Copy link
Owner

leycec commented Jun 2, 2015

I hope that presence of libvterm-neovim in dev-libs in main portage tree puts an end to the discussion “what category this package should belong to”.

You win! I still disagree with that classification, but... I suppose it doesn't particularly matter. We'd better do this the Portage way before other ebuilds start depending on libvterm.

Thanks for noticing the new libvterm-neovim package, bringing this to my attention, and fixing this. As always, you're awesome.

@leycec
Copy link
Owner

leycec commented Jun 2, 2015

O.K.!

Everything looks great except for the commit installing bot-ci's license. Per the Gentoo development guide for the src_install() phase function:

Note: There is no need to dodoc COPYING! The license belongs to ${PORTDIR}/licenses. Sometimes though, you might want to install COPYING regardless, if it explains how different licenses are applied to different parts of the application, for example.

Since bot-ci only requires the vanilla MIT license, the latter clause doesn't really apply, implying its LICENSE should not be installed. If you wouldn't mind removing that commit, I'd be happy to accept everything else without changes.

@ZyX-I
Copy link
Collaborator Author

ZyX-I commented Jun 2, 2015

Removed commit that does LICENSE copying.

ZyX-I added 4 commits June 2, 2015 20:36
libvterm-neovim was put into dev-libs into *main portage tree*. So this location
for this package should be considered official.
They are trying to install identical files to some locations, so cannot coexist.
@leycec
Copy link
Owner

leycec commented Jun 3, 2015

Superb. It's in!

leycec added a commit that referenced this pull request Jun 3, 2015
app-misc/powerline: Testing-related fixes.

It's all thanks to the illustrious ZyX-I, as ever.
@leycec leycec merged commit 822dfc0 into leycec:master Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants