Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cataclysm-dda: Patch to add USE_XDG_DIR option in 0.9c #44

Merged
merged 1 commit into from
Mar 23, 2016

Conversation

lucianposton
Copy link
Contributor

Fixes #43

The patch seems to work fine. I also added a warning when upgrading from the prior version in pkg_postinst().

The more I thought about it, the more I think you probably wouldn't want to modify the 0.9c behavior, but here's that patch anyway, in case you want to pull it.

@leycec
Copy link
Owner

leycec commented Mar 23, 2016

The patch seems to work fine.

Yay! Thanks for this valuable fix.

The more I thought about it, the more I think you probably wouldn't want to modify the 0.9c behavior....

Yeah. I'm totally O.K. with butchering the default 0.9c behaviour, particularly as this is an official patch.

That said, I have two concerns which I'm happy to address myself:

  1. The patch should only be conditionally applied to 0.9c. The live ebuild should, of course, remain unpatched. Perhaps Portage simply ignores epatch() attempts when no such patch exists? If so, I'd still prefer that the patch be conditionally applied. EDIT: Ah, I see. You've de-linked the 0.9c-r3 and 9999 ebuilds. That certainly does work, but I'd prefer to maintain the symbolic link for now. I'll relink these ebuilds shortly. Null sweat, omae.
  2. A new xdg USE flag should be added, disabled by default. If disabled, the USE_HOME_DIR option should be passed to emake(); else, the USE_XDG_DIR option should be passed to emake(). I actually prefer USE_HOME_DIR myself, so I'm not quite sure why I coerced USE_XDG_DIR. <shrug/>

This is really all my fault, however. I'm happy to see to these changes myself. Thanks again, and may the zombie-infested highways of life be with you.

@leycec leycec merged commit ac83a23 into leycec:master Mar 23, 2016
@leycec
Copy link
Owner

leycec commented Mar 23, 2016

It is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants