Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update media-sound/vgmplay to 0.40.9 #68

Merged
merged 1 commit into from
Jan 29, 2019

Conversation

ValleyBell
Copy link
Contributor

I kept the 0.40.8 ebuild and restored the 0.40.7 ebuild as well, because I didn't see a reason for removing it.

With VGMPlay 0.40.9, I changed the Makefile again, now setting the options works as it should.

I also tried to clear up the license confusion a bit. (It's not like that makes it any better though.)

I kept the ebuild for 0.40.8 and restored the one for 0.40.7
@leycec
Copy link
Owner

leycec commented Jan 26, 2019

Oh, man. Thank you so nostalgically much for this. I love VGMPlay in various ways that I probably shouldn't. As it's my 49th birthday tomorrow (...gulp), I'll be hogtied for the next several days. Assuming I don't come down with a "bad case of the Mondays," I'll giddily merge this in early next week.

You rock, @ValleyBell. 🎶 🎧

@leycec
Copy link
Owner

leycec commented Jan 29, 2019

Looks awesome, as expected. I mildly regret my caustic commentary concerning licensing. I was quite frustrated at the time and... well, I didn't think anyone would ever actually read my ebuilds. They did. Now, I too feel public shame.

Thanks for helping to clarify VGMPlay's licensing conundrum a bit, bumping the release, installing correct documentation, and substantially improving our use of USE flags. For pointless edification, note that command-line options may be efficiently defined from USE flags via the EAPI 5 usex function: e.g.,

# Instead of this...
use opl  && VGMPLAY_MAKE_OPTIONS+=( DISABLE_HWOPL_SUPPORT=0 ) || VGMPLAY_MAKE_OPTIONS+=( DISABLE_HWOPL_SUPPORT=1 )

# ...just do this! ;()
VGMPLAY_MAKE_OPTIONS+=( DISABLE_HWOPL_SUPPORT=$(usex opl 0 1) )

Sweet, eh? And don't sweat those pedantic details. I'll patch that up for you after the merger. Let's do this!

@leycec leycec merged commit c85833b into leycec:master Jan 29, 2019
@ValleyBell
Copy link
Contributor Author

Ohh, that usex function is indeed awesome!
Thanks for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants