Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cataclysm:DDA Urls #71

Merged
merged 1 commit into from
Mar 31, 2019
Merged

Update Cataclysm:DDA Urls #71

merged 1 commit into from
Mar 31, 2019

Conversation

winny-
Copy link
Contributor

@winny- winny- commented Mar 30, 2019

I did not test the revision bump + HOMEPAGE change in the ebuilds. I wish I knew how to do that without a great deal of effort :)

@leycec
Copy link
Owner

leycec commented Mar 31, 2019

Awesome. By visual inspection (read: poorly informed post-hoc rationalization), this changeset looks great. Yet again, the C:DDA userbase shames me with superior intellect and excrutiating attention to detail.

Thanks, @winny-! Bother free is, indeed, the way to be. 🐻 🍯

@leycec leycec merged commit 76bbf86 into leycec:master Mar 31, 2019
@leycec
Copy link
Owner

leycec commented Mar 31, 2019

Oh, and please note for future submissions that the Portage convention is to only bump ebuild revision numbers on significant internal improvements. Since URL redirects aren't necessarily significant (with respect to ebuild behaviour, anyway), this pull request probably shouldn't have bumped ebuild revisions.

That said, this is a subjective grey area – and I was planning on bumping ebuild revisions anyway after resolving #69. So, this wouldn't be the worst thing that's happened to me today. That would be my receding hairline, which clever comb overs now fail to hide. ...middle-age problems.

@winny-
Copy link
Contributor Author

winny- commented Mar 31, 2019

Super! Thank you for the feedback - I follow what you mean with the version bump - especially for metadata changes that don't affect the contents.

I aspire to test every ebuild change I make, but somehow testing system packages is often surprisingly nontrivial. Thanks again for bearing with my only-visually-inspected PR. Interesting essay - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants