Skip to content

CI(codeql): Scan GitHub Actions workflows - #414

Open
ModeSevenIndustrialSolutions wants to merge 1 commit into
lfreleng-actions:mainfrom
modeseven-lfreleng-actions:ci/codeql-missing-languages
Open

ModeSevenIndustrialSolutions wants to merge 1 commit into
lfreleng-actions:mainfrom
modeseven-lfreleng-actions:ci/codeql-missing-languages

Conversation

@ModeSevenIndustrialSolutions

Copy link
Copy Markdown
Contributor

Summary

The advanced CodeQL workflow calls the shared reuse-python-codeql workflow, which scans Python only, so this repository's GitHub Actions workflows, a language GitHub detects here, have never been scanned.

This adds a sibling other-languages job to .github/workflows/codeql.yml scanning actions, hardened exactly as the shared workflow's job is:

  • egress blocked to the org allow-list (harden-runner-block-action + harden-runner in block mode);
  • persist-credentials: false on checkout;
  • the same pinned action versions, each verified as a commit SHA matching its version comment.

Found by the new CodeQL Language Coverage check in lfreleng-actions/github-security-report-action#173; same fix as lfreleng-actions/dependamerge#524.

Validation

  • zizmor --persona auditor, online mode: no findings.
  • Every prek hook passes, including yamllint and actionlint.
  • After merge, the first scheduled or dispatched run should upload a language:actions analysis, which clears this repository from the report's Language Coverage table.

The advanced CodeQL workflow calls the shared reuse-python-codeql
workflow, which scans Python only, so this repository's GitHub Actions
workflows, a language GitHub detects here, have never been scanned.

Add a sibling job scanning the actions language, hardened exactly as
the shared workflow's job is: egress blocked to the org allow-list,
credentials not persisted, and the same pinned action versions. A
one-entry language matrix gives the upload the same category shape as
the Python scan's.

Co-authored-by: Claude <noreply@anthropic.com>
Signed-off-by: Matthew Watkins <mwatkins@linuxfoundation.org>
@ModeSevenIndustrialSolutions
ModeSevenIndustrialSolutions requested review from a team and a balanced review from Copilot September 25, 2026 05:15
@github-actions github-actions Bot added the CI CI and tests updates label Sep 25, 2026
@sonarqubecloud

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The new job correctly adds the missing analysis while matching the repository’s established security controls.

Review effort: Balanced
Findings: None

What changed in this PR

Adds CodeQL coverage for GitHub Actions workflows alongside the existing Python scan.

Changes:

  • Adds an actions language analysis job.
  • Applies pinned, hardened CI dependencies and restricted permissions.
File Description
.github/​workflows/​codeql.yml Adds the hardened GitHub Actions CodeQL scan.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI CI and tests updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants