-
Notifications
You must be signed in to change notification settings - Fork 154
Add eslint-plugin-css-modules #1810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add eslint-plugin-css-modules #1810
Conversation
|
@sakit0 is attempting to deploy a commit to the Liam Team on Vercel. A member of the Team first needs to authorize it. |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the additions! Since the linting passes locally, I believe the changes have been added without any issues. As long as the GitHub Actions CI (especially the lint step) passes, I think it’s good to go and can be merged without problems!
Issue
Why is this change needed?
We need to add
eslint-plugin-css-modules
to detect undefined class names when using CSS Modules. This improves type safety for CSS Modules and helps catch errors early in development.What would you like reviewers to focus on?
eslint-plugin-css-modules
dependency is correctly addedTesting Verification
What was done
eslint-plugin-css-modules
to dependenciescss-modules
plugin andno-undef-class
rule to the base ESLint configuration filepnpm-lock.yaml
Detailed Changes
eslint-plugin-css-modules
version 2.12.0 topackage.json
css-modules
pluginno-undef-class
rule with camelCase optionAdditional Notes