JumpErrorEstimator::integrate_slits option #4044
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I must have made this mistake in the initial refactoring and then just copied it again and again, and because it was a performance issue rather than a correctness issue CI never caught it, and because it wasn't *much* of a performance issues my profiling never caught it.
Now I know why I had those there - as prerequests. But we do the prerequests in init_context() so we don't need redundant ones here.
There's not really a way to autodetect what we want to do here based on other options, the way we do for boundary sides.
In other jump error estimators we get the dx/dxi prerequests from the FEMap implicitly via get_dphi() or get_d2phi(); here we should be calling for it explicitly.
This passes options along to PETSc and silences their unused-option warnings
|
Job Test MOOSE ARM mac on 7ca6e1b : invalidated by @roystgnr |
Hopefully our CI environments are complaining about this because they're strict with C++17, not because they're incomplete with it...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a bit of a red herring for the flex-IGA bug hunt I wrote it for, but it could still be useful for making our error indicators work properly on flex-IGA meshes.