- 
                Notifications
    You must be signed in to change notification settings 
- Fork 299
Update MetaPhysicL #4300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
Update MetaPhysicL #4300
Conversation
| I believe idaholab/moose#31813 will enable this to pass once it makes its way to MOOSE master | 
This update includes a major version change so there will likely be a decent amount of work in MOOSE at least to allow testing on this PR to be green. I already have a MOOSE fully compatible with the MetaPhysicL changes but the trick is that I'll need to make a MOOSE that is compatible with both old and new MetaPhysicL in order to allow us to have CI green all the way through this update process
3d58e5a    to
    7b1e843      
    Compare
  
    | Well, I was expecting to need the swath of  
 Double checking my own  Did one of us screw up something basic that's causing the simple  | 
| Job Coverage, step Generate coverage on 1cc1b6e wanted to post the following: Coverage
 Warnings
 This comment will be updated on new commits. | ||||||||||||||||||||||||||
| Oh, of course that was it.  We may even have to test for something blander like  | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait for the MOOSE compatibility to be merged and those tests to pass before we merge, of course.
An, as long as we have to kick the PR later anyway, I'd say let's do so by reordering the commits here so the intermediate git hashes will build+pass with MetaPhysicL too, but either way I'm happy with this.
| idaholab/moose#31813 passed so that's promising | 
This update includes a major version change so there will likely be a decent amount of work in MOOSE at least to allow testing on this PR to be green. I already have a MOOSE fully compatible with the MetaPhysicL changes but the trick is that I'll need to make a MOOSE that is compatible with both old and new MetaPhysicL in order to allow us to have CI green all the way through this update process