Skip to content

Conversation

@lindsayad
Copy link
Member

This update includes a major version change so there will likely be a decent amount of work in MOOSE at least to allow testing on this PR to be green. I already have a MOOSE fully compatible with the MetaPhysicL changes but the trick is that I'll need to make a MOOSE that is compatible with both old and new MetaPhysicL in order to allow us to have CI green all the way through this update process

@lindsayad
Copy link
Member Author

I believe idaholab/moose#31813 will enable this to pass once it makes its way to MOOSE master

This update includes a major version change so there will likely
be a decent amount of work in MOOSE at least to allow testing on this
PR to be green. I already have a MOOSE fully compatible with the
MetaPhysicL changes but the trick is that I'll need to make a MOOSE
that is compatible with both old and new MetaPhysicL in order to allow
us to have CI green all the way through this update process
@roystgnr
Copy link
Member

Well, I was expecting to need the swath of using std::foo; and s/std::foo/foo downstream, but what's up with:

ADRealForward.h:13:10: fatal error: metaphysicl/metaphysicl_version.h: No such file or directory ???

Double checking my own make install I see metaphysicl_version.h right where it should be, and ... oh, but this is interesting, from one of the "passing" recipes:

checking for MetaPhysicL NumberArray support... no
>>> Metaphysicl not found, you may need to run 'git submodule update --init' first <<<

Did one of us screw up something basic that's causing the simple NumberArray instantiation in libmesh_metaphysicl.m4 to fail? Maybe when I juggled include directives I missed something that numberarray.h needed, but we still passed MetaPhysicL recipes because all the tests there include more than just that one header?

@moosebuild
Copy link

Job Coverage, step Generate coverage on 1cc1b6e wanted to post the following:

Coverage

e27e71 #4300 1cc1b6
Total Total +/- New
Rate 65.01% 65.01% +0.00% 56.00%
Hits 76961 76962 +1 14
Misses 41430 41429 -1 11

Diff coverage report

Full coverage report

Warnings

  • New new line coverage rate 56.00% is less than the suggested 90.0%

This comment will be updated on new commits.

@roystgnr
Copy link
Member

Oh, of course that was it. We may even have to test for something blander like metaphysicl_exceptions.h in the long run, if we want a robust solution to the chicken-and-egg problem of figuring out whether we can configure with MetaPhysicL before we've configured MetaPhysicL; I could imagine a config dependency slipping into raw_type.h eventually.

Copy link
Member

@roystgnr roystgnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for the MOOSE compatibility to be merged and those tests to pass before we merge, of course.

An, as long as we have to kick the PR later anyway, I'd say let's do so by reordering the commits here so the intermediate git hashes will build+pass with MetaPhysicL too, but either way I'm happy with this.

@lindsayad
Copy link
Member Author

idaholab/moose#31813 passed so that's promising

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants