Threadpool Refactor #1168
Open
Threadpool Refactor #1168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jan 26, 2025
COM8
force-pushed
the
feature/thread_pool_v2
branch
3 times, most recently
from
eba6332 to
a6c8fca
Compare
|
Hi, I would like to suggest use a third thread pool implementation: https://github.com/bshoshany/thread-pool |
Agree. If I'm unable to fix the macos socket issues, I will most likely switch and experiment with that one. Good point. |
|
The ASIO thread pool is also a good choice. |
COM8
force-pushed
the
feature/thread_pool_v2
branch
from
a15f238 to
bba1f7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors
cpr::ThreadPoolto get rid of all those deadlocks and overly complex code making it at least a bit simpler.Fixes:
Docs:
cpr::ThreadPoolDocumentation docs#54