Skip to content

C API: Add GEOSGeoJSONWriter_setOutputDimension #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025

Conversation

oreilles
Copy link
Contributor

No description provided.

void
GEOSGeoJSONWriter_setOutputDimension(GeoJSONWriter* writer, int dim)
{
GEOSGeoJSONWriter_setOutputDimension_r(handle, writer, dim);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test?

@dr-jts dr-jts added the Enhancement New feature or feature improvement. label Apr 24, 2025
@oreilles
Copy link
Contributor Author

oreilles commented Apr 26, 2025

Just noticed that GEOSWKBWriter_getOutputDimension_r use 0 as the error code, while GEOSWKTWriter_getOutputDimension_r uses -1. What value is the recommended one nowadays ? ( I guess it's not that important since valid values are 2:4 anyway. )

@oreilles oreilles force-pushed the geojsonwriter-capi branch from 8eeb34f to 6ba4281 Compare May 3, 2025 21:17
@pramsey pramsey merged commit a31dd35 into libgeos:main May 6, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or feature improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants