update GMM++ to the version 5.3, and clean up a bit code #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This fork mostly exists to facilitate compilation across the different OS (the problematic one being mostly Windows, which is why this repo includes a pre-compiled dll of blas and lapack). We can update it as long as it doesn't break any existing code/unit tests. |
Author
|
This PR should not break anything. I have tested it with libigl. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You have probably seen these warnings related to deprecated things in GMM++ 4.2, etc.
Please, review the changes carefully ;-)
PS. I have seen some interesting TODOs inside CoMiSo code, I think some of them should be moved to issue on github as bugs. But this depends how much effort you want to spend on maintaining this fork of CoMISo.