update openblas dll to be v0.3.6 #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igl CoMISo on Windows under Release mode
Contributor
|
Thank you for the fix! Can someone else with a windows machine confirm that this works with the latest version of libigl? |
|
It worked for me. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the runtime error of libigl CoMISo on Windows under Release mode.
Related libigl issue: #1050
For us, the problem was similar as in our application runs fine in debug mode but not in release due to the library not being the most up-to-date. After replacing it with the v0.3.6 (released mid August), the issue gets resolved.
In fact, using v0.2.15 (the immediate next version of the current version) also gets rid of the runtime error.
Although as in the original post, "deleting the BLAS libraries from CoMISo and linking instead to OpenBLAS compiled from source" is the right way to fix it, updating the dll will also fix it and doesn't require other changes.
This is a temporary solution until anyone implements what is mentioned in this comment.