Skip to content

关于国战模式的翻新和新武将的添加 #2320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 49 commits into
base: PR-Branch
Choose a base branch
from

Conversation

rintim
Copy link
Member

@rintim rintim commented Mar 8, 2025

PR受影响的平台

诱因和背景

国战模式已经经过了多年的维护,目前的代码已然成为了屎山

为了无名杀后续更好的维护下去,目前是时候尝试翻新一下现有的国战模式,同时为新武将做好准备

PR描述

注意: feature/guozhan-new分支将作为国战翻新的基础分支,独立于PR-Branch;与国战翻新相关的代码请提交Pull Request到该分支下

其余内容待定

PR测试

显然没有,目前等待完工

扩展适配

后续待定

检查清单

  • 我没有把该PR提交到master分支
  • commit中没有无用信息,和没有具体内容的“bugfix”
  • 我已经进行了充足的测试,且现有的测试都已通过
  • 如果此次PR中添加了新的武将,则我已在character/rank.js中添加对应的武将强度评级,并对双人武将/复姓武将添加name:xxx的参数
  • 如果此次PR中添加了新的语音文件,则我已在lib.translate中加入语音文件的文字台词
  • 如果此次PR涉及到新功能的添加,我已在PR描述中写入详细文档
  • 如果此次PR需要扩展跟进,我已在扩展适配中写入详细文档
  • 如果这个PR解决了一个issue,我在诱因和背景中明确链接到该issue
  • 我保证该PR中没有随意修改换行符等内容,没有制造出大量的Diff
  • 我保证该PR遵循项目中.editorconfigeslint.config.mjsprettier.config.mjs所规定的代码样式,并且已经通过prettier格式化过代码

@rintim rintim added this to the v1.10.18 milestone Mar 8, 2025
@rintim rintim requested a review from a team March 8, 2025 17:58
@rintim rintim moved this to Doing in Noname Entirety Mar 8, 2025
@nonameShijian
Copy link
Collaborator

我不建议导出的对象冻结

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Doing
Development

Successfully merging this pull request may close these issues.

6 participants