-
Notifications
You must be signed in to change notification settings - Fork 668
关于国战模式的翻新和新武将的添加 #2320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
rintim
wants to merge
49
commits into
PR-Branch
Choose a base branch
from
feature/guozhan-new
base: PR-Branch
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
关于国战模式的翻新和新武将的添加 #2320
+8,519
−5,368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt` when functions of `Player` use properties of `GameEvent`.
我不建议导出的对象冻结 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR受影响的平台
无
诱因和背景
国战模式已经经过了多年的维护,目前的代码已然成为了屎山
为了无名杀后续更好的维护下去,目前是时候尝试翻新一下现有的国战模式,同时为新武将做好准备
PR描述
注意:
feature/guozhan-new
分支将作为国战翻新的基础分支,独立于PR-Branch
;与国战翻新相关的代码请提交Pull Request到该分支下PR测试
显然没有,目前等待完工
扩展适配
后续待定
检查清单
master
分支character/rank.js
中添加对应的武将强度评级,并对双人武将/复姓武将添加name:xxx
的参数lib.translate
中加入语音文件的文字台词PR描述
中写入详细文档扩展适配
中写入详细文档诱因和背景
中明确链接到该issue.editorconfig
、eslint.config.mjs
和prettier.config.mjs
所规定的代码样式,并且已经通过prettier
格式化过代码