Skip to content

为chooseToMove、chooseToGive、chooseToDiscard、chooseButton、chooseCard、choosePlayerCard、discardPlayerCard、gainPlayerCard以及主动技的选牌添加全选/反选按钮喵 #2824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 16, 2025

Conversation

IceCola97
Copy link
Contributor

PR受影响的平台

诱因和背景

是个老需求了喵,给大量牌的场景添加了全选和反选喵

PR描述

  1. 为chooseToMove、chooseToGive、chooseToDiscard、chooseButton、chooseCard、choosePlayerCard、discardPlayerCard以及gainPlayerCard添加全选/反选按钮喵
  2. 重写了game.$elementGoto,让其可以并发播放多个动画喵
  3. 添加了对话框里面全选反选按钮的CSS喵

PR测试

已经通过了单人和联机的测试喵

扩展适配

检查清单

  • 我没有把该PR提交到master分支
  • commit中没有无用信息,和没有具体内容的“bugfix”
  • 我已经进行了充足的测试,且现有的测试都已通过
  • 若我拥有PR标签权限,则已确保为该PR打上标签;若我未拥有PR标签权限且该PR仍需继续提交内容,则已确保为该PR名称打上WIP直到本PR内容全部提交
  • 如果此次PR中添加了新的武将,则我已在character/rank.js中添加对应的武将强度评级,并对双人武将/复姓武将添加name:xxx的参数
  • 如果此次PR中添加了新的语音文件,则我已在lib.translate中加入语音文件的文字台词
  • 如果此次PR涉及到新功能的添加,我已在PR描述中写入详细文档
  • 如果此次PR需要扩展跟进,我已在扩展适配中写入详细文档
  • 如果这个PR解决了一个issue,我在诱因和背景中明确链接到该issue
  • 我保证该PR中没有随意修改换行符等内容,没有制造出大量的Diff
  • 我保证该PR遵循项目中.editorconfigeslint.config.mjsprettier.config.mjs所规定的代码样式,并且已经通过prettier格式化过代码

@IceCola97 IceCola97 changed the title 为chooseToMove、chooseToGive、chooseToDiscard、chooseButton、chooseCard、choosePlayerCard、discardPlayerCard以及gainPlayerCard添加全选/反选按钮喵 为chooseToMove、chooseToGive、chooseToDiscard、chooseButton、chooseCard、choosePlayerCard、discardPlayerCard、gainPlayerCard以及主动技的选牌添加全选/反选按钮喵 Jul 14, 2025
@IceCola97 IceCola97 requested a review from xizifu July 14, 2025 11:38
@Spmario233
Copy link
Collaborator

怎么没考虑complexCard

@IceCola97
Copy link
Contributor Author

怎么没考虑complexCard

唔唔已经补上了喵

@IceCola97 IceCola97 marked this pull request as draft July 15, 2025 02:46
@IceCola97 IceCola97 changed the title 为chooseToMove、chooseToGive、chooseToDiscard、chooseButton、chooseCard、choosePlayerCard、discardPlayerCard、gainPlayerCard以及主动技的选牌添加全选/反选按钮喵 [WIP] 为chooseToMove、chooseToGive、chooseToDiscard、chooseButton、chooseCard、choosePlayerCard、discardPlayerCard、gainPlayerCard以及主动技的选牌添加全选/反选按钮喵 Jul 15, 2025
@IceCola97 IceCola97 marked this pull request as ready for review July 15, 2025 08:12
@IceCola97 IceCola97 changed the title [WIP] 为chooseToMove、chooseToGive、chooseToDiscard、chooseButton、chooseCard、choosePlayerCard、discardPlayerCard、gainPlayerCard以及主动技的选牌添加全选/反选按钮喵 为chooseToMove、chooseToGive、chooseToDiscard、chooseButton、chooseCard、choosePlayerCard、discardPlayerCard、gainPlayerCard以及主动技的选牌添加全选/反选按钮喵 Jul 15, 2025
@IceCola97 IceCola97 merged commit 346a089 into libnoname:PR-Branch Jul 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants