-
Notifications
You must be signed in to change notification settings - Fork 761
chooseToComapre相关修改 #3018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zhonghui1966
wants to merge
14
commits into
libnoname:PR-Branch
Choose a base branch
from
zhonghui1966:PR-Branch
base: PR-Branch
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chooseToComapre相关修改 #3018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
现在没有大量diff了 😄 |
Collaborator
|
拼点存在规则漏洞,已经进入拼点流程之后的无法拼点判定只有无手牌,直接对初始手牌进行filter可能会让秦宓天辩类技能无法使用,建议完善“可拼点”概念 |
Contributor
Author
就是兼容onCompare?让秦宓这些有手牌就能天辩? |
Contributor
Author
我按我的理解改完了,但是还有一个问题,秦宓这一类的武将如果手牌全部无法用于拼点,进入选牌的时候技能按钮会出不来,我看tianbian的filter是过了的,不知道为什么 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR受影响的平台
无
诱因和背景
chooseToCompare内的filterCard接口不完善,ai检测不到并且如果所有手牌都不通过检测会导致卡住
PR描述
完善chooseToCompare事件:
1.增加lib.filter.canBeComapred,传参有card, player, event,包含checkMod,传参同上,event传进mod里是技能名,想整花活自己getHistory去
2.修改player.js中的canCompare, chooseToCompare函数,适配修改
3.修改content.js中的三种chooseToCompare事件,均适配event.position和新的filterCard
4.修改手杀势杨弘,梦司马昭,手杀笮融,界太史慈的技能以适配新的修改
prettier格式化
PR测试
测过了
扩展适配
修改filterCard的扩展要么重新apply一遍lib.filter.canBeComapred(可能导致相互覆盖),要么也改成mod的形式
检查清单