feat: async middleware #3204
Open
feat: async middleware #3204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds middleware handlers for protocol streams. They are invoked
for incoming and outgoing streams and allow access to the stream
and connection before the handler (incoming) or caller (outgoing)
receive them.
This way middleware can wrap streams in transforms, or deny access,
or something else.
```ts
libp2p.use('/my/protocol/1.0.0', (stream, connection, next) => {
const originalSource = stream.source
// increment all byte values in the stream by one
stream.source = (async function * () {
for await (const buf of originalSource) {
buf = buf.map(val => val + 1)
yield buf
}
})()
// pass the stream on to the next middleware
next(stream, connection)
})
```
fix: infinte loop fix: cleanup failed streams chore: add some logging test: check failed middleware
|
I think you might need to rebase your changes on top of main, there appear to be a bunch of duplicated commits here? |
Changed the PR to target |
|
Ah, yeah sorry - my mistake |
Wasn't sure which branch to the do the PR against, my bad :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat: async middleware
fix: infinte loop
fix: cleanup failed streams
chore: add some logging
test: check failed middleware
Notes & open questions
Change checklist