feat(webrtc): promote to stable release #5854
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariusc93
reviewed
Feb 12, 2025
| @@ -119,6 +121,7 @@ libp2p-relay = { workspace = true, optional = true } | |||
| libp2p-rendezvous = { workspace = true, optional = true } | |||
| libp2p-request-response = { workspace = true, optional = true } | |||
| libp2p-swarm = { workspace = true } | |||
| libp2p-webrtc = { workspace = true, optional = true } | |||
There was a problem hiding this comment.
Should we move this under [target.'cfg(not(target_arch = "wasm32"))'.dependencies]?
Comment on lines
+126
to
+128
| #[cfg(feature = "webrtc")] | ||
| #[doc(inline)] | ||
| pub use libp2p_webrtc as webrtc; |
There was a problem hiding this comment.
Suggested change
| #[cfg(feature = "webrtc")] | |
| #[doc(inline)] | |
| pub use libp2p_webrtc as webrtc; | |
| #[cfg(feature = "webrtc")] | |
| #[cfg(not(target_arch = "wasm32"))] | |
| #[doc(inline)] | |
| pub use libp2p_webrtc as webrtc; |
jxs
reviewed
Feb 13, 2025
There was a problem hiding this comment.
Hi Elena, thanks for this! The thing is, I wonder if we can call it stable as the history we have with webrtc-rs and namely the upgrade to 0.11 shows. Nonetheless wdyt of merging it first before this Elena?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
v0.9.0oflibp2p-webrtc.libp2p-webrtcaslibp2p::webrtc.Notes & open questions
Discussed in #5819 (review).
Change checklist
I have added tests that prove my fix is effective or that my feature works