Skip to content

factor out parts of IMG_LoadJPG where locals can be clobbered by longjmp (SDL2 version) #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025

Conversation

sezero
Copy link
Contributor

@sezero sezero commented Apr 9, 2025

Closes: #435

CC: @smcv

@sezero sezero requested a review from slouken April 9, 2025 04:25
@smcv
Copy link
Contributor

smcv commented Apr 9, 2025

Same comments as in #545

@sezero
Copy link
Contributor Author

sezero commented Apr 10, 2025

PING @slouken

@sezero sezero force-pushed the jpg-longjmp2 branch 2 times, most recently from 1f7fd35 to 1766520 Compare April 11, 2025 21:10
Also sanitize error setting a bit in IMG_LoadPNG()

Fixes libsdl-org#435
@sezero sezero merged commit 0dfa3d8 into libsdl-org:SDL2 Apr 15, 2025
8 checks passed
@sezero sezero deleted the jpg-longjmp2 branch April 15, 2025 09:25
@sezero
Copy link
Contributor Author

sezero commented Apr 15, 2025

This is in now. If there are any issues, please open a new ticket for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants