Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fuzzing, invariants, solvency #952

Draft
wants to merge 50 commits into
base: feat/vaults
Choose a base branch
from
Draft

test: fuzzing, invariants, solvency #952

wants to merge 50 commits into from

Conversation

tamtamchik
Copy link
Member

@tamtamchik tamtamchik commented Feb 19, 2025 •
edited
Loading

  • Invariant testing for Lido accounting oracle report with stVaults
  • Invariant testing for stETH share rate consistency
  • StakingVault solvency tests

sergeyWh1te and others added 24 commits January 10, 2025 17:40
@sergeyWh1te
feat: test shareRate with fuzzing
afc5fa1
@tamtamchik
Merge branch 'feat/vaults' into feat/vaults-fuzzing-share-rate
e772d2a
@sergeyWh1te
feat: test shareRate with fuzzing
0b6fc5c
@sergeyWh1te
feat: test shareRate with fuzzing
6317957
@tamtamchik
chore: some refactoring
c289fb8
@sergeyWh1te
feat: test shareRate with fuzzing
d79df96
@sergeyWh1te
feat: fuzz oracleReport
167c387
@tamtamchik
chore: add oracle report related contracts
2386b48
@tamtamchik
fix: accounting initialization
79ecbbb
@sergeyWh1te
feat: added _sharesRequestedToBurn to fuzzing
7fc5b7f
@sergeyWh1te
feat: added _sharesRequestedToBurn to fuzzing
c9f78d0
@sergeyWh1te
feat: refactor fuzz.ProtocolDeployment
166ef4b
@sergeyWh1te
feat: fix incorrect timestamp for Report
c39aeea
@tamtamchik
chore: add todos
7d05ee2
@sergeyWh1te
feat: wip fuzz handleOracleReport
1203e29
@sergeyWh1te
feat: fuzz clValidators after report
6ae1888
@sergeyWh1te
feat: try to get elRewards
ea08979
@sergeyWh1te
feat: invariant_handleOracleReport
f7870a8
@sergeyWh1te
feat: invariant_handleOracleReport
02ac654
@sergeyWh1te
feat: check invariant lido.transfer
490652e
@sergeyWh1te
feat: check invariant_vaultsDonAffectSharesRate
8b88a72
@tamtamchik
Merge remote-tracking branch 'origin/feat/vaults' into feat/vaults-fu…
7f6f404 
…zzing-share-rate

# Conflicts:
#	package.json
#	test/0.4.24/contracts/StakingRouter__MockForLidoAccounting.sol
@tamtamchik
feat: stabilize tests
e9a302d
@tamtamchik
Merge branch 'feat/vaults' into feat/vaults-fuzzing
9a131aa
@tamtamchik tamtamchik added tests When it comes to testing the code vaults labels Feb 19, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 19, 2025 •
edited
Loading

badge

Hardhat Unit Tests Coverage Summary

Filename                                                                Stmts    Miss  Cover    Missing
--------------------------------------------------------------------  -------  ------  -------  ---------------------------------------------------------
contracts/0.4.24/Lido.sol                                                 205       7  96.59%   754, 759, 802-814, 963-964
contracts/0.4.24/StETH.sol                                                 79       0  100.00%
contracts/0.4.24/StETHPermit.sol                                           15       0  100.00%
contracts/0.4.24/lib/Packed64x4.sol                                         5       0  100.00%
contracts/0.4.24/lib/SigningKeys.sol                                       36       0  100.00%
contracts/0.4.24/lib/StakeLimitUtils.sol                                   37       0  100.00%
contracts/0.4.24/nos/NodeOperatorsRegistry.sol                            512       0  100.00%
contracts/0.4.24/oracle/LegacyOracle.sol                                   72       0  100.00%
contracts/0.4.24/utils/Pausable.sol                                         9       0  100.00%
contracts/0.4.24/utils/Versioned.sol                                        5       0  100.00%
contracts/0.6.12/WstETH.sol                                                17       0  100.00%
contracts/0.8.25/Accounting.sol                                            83       5  93.98%   118-121, 340, 368
contracts/0.8.25/interfaces/IDepositContract.sol                            0       0  100.00%
contracts/0.8.25/interfaces/ILido.sol                                       0       0  100.00%
contracts/0.8.25/interfaces/IOracleReportSanityChecker.sol                  0       0  100.00%
contracts/0.8.25/interfaces/IPostTokenRebaseReceiver.sol                    0       0  100.00%
contracts/0.8.25/interfaces/IStakingRouter.sol                              0       0  100.00%
contracts/0.8.25/interfaces/IWithdrawalQueue.sol                            0       0  100.00%
contracts/0.8.25/lib/GIndex.sol                                            33      18  45.45%   22, 34, 55, 63-70, 79, 86-101
contracts/0.8.25/lib/SSZ.sol                                               16      11  31.25%   31-100, 222-235
contracts/0.8.25/utils/AccessControlConfirmable.sol                        30       0  100.00%
contracts/0.8.25/utils/PausableUntilWithRoles.sol                           3       0  100.00%
contracts/0.8.25/vaults/Dashboard.sol                                      86       1  98.84%   378
contracts/0.8.25/vaults/Delegation.sol                                     31       0  100.00%
contracts/0.8.25/vaults/Permissions.sol                                    33       1  96.97%   267
contracts/0.8.25/vaults/StakingVault.sol                                  121       0  100.00%
contracts/0.8.25/vaults/VaultFactory.sol                                   39       0  100.00%
contracts/0.8.25/vaults/VaultHub.sol                                      178      42  76.40%   94, 184, 312, 353-387, 466-476, 511-541, 554-563, 569-584
contracts/0.8.25/vaults/interfaces/IStakingVault.sol                        0       0  100.00%
contracts/0.8.25/vaults/predeposit_guarantee/CLProofVerifier.sol           11       0  100.00%
contracts/0.8.25/vaults/predeposit_guarantee/PredepositGuarantee.sol      149       0  100.00%
contracts/0.8.4/WithdrawalsManagerProxy.sol                                61       0  100.00%
contracts/0.8.9/BeaconChainDepositor.sol                                   21       2  90.48%   48, 51
contracts/0.8.9/Burner.sol                                                 72       0  100.00%
contracts/0.8.9/DepositSecurityModule.sol                                 128       0  100.00%
contracts/0.8.9/EIP712StETH.sol                                            16       0  100.00%
contracts/0.8.9/LidoExecutionLayerRewardsVault.sol                         16       0  100.00%
contracts/0.8.9/LidoLocator.sol                                            22       0  100.00%
contracts/0.8.9/OracleDaemonConfig.sol                                     28       0  100.00%
contracts/0.8.9/StakingRouter.sol                                         316       0  100.00%
contracts/0.8.9/WithdrawalQueue.sol                                        88       0  100.00%
contracts/0.8.9/WithdrawalQueueBase.sol                                   146       0  100.00%
contracts/0.8.9/WithdrawalQueueERC721.sol                                  89       0  100.00%
contracts/0.8.9/WithdrawalVault.sol                                        21       0  100.00%
contracts/0.8.9/lib/Math.sol                                                4       0  100.00%
contracts/0.8.9/lib/PositiveTokenRebaseLimiter.sol                         22       0  100.00%
contracts/0.8.9/lib/UnstructuredRefStorage.sol                              2       0  100.00%
contracts/0.8.9/oracle/AccountingOracle.sol                               190       2  98.95%   154-155
contracts/0.8.9/oracle/BaseOracle.sol                                      89       1  98.88%   397
contracts/0.8.9/oracle/HashConsensus.sol                                  263       1  99.62%   1005
contracts/0.8.9/oracle/ValidatorsExitBusOracle.sol                         91       2  97.80%   138, 315
contracts/0.8.9/proxy/OssifiableProxy.sol                                  17       0  100.00%
contracts/0.8.9/sanity_checks/OracleReportSanityChecker.sol               217       1  99.54%   856
contracts/0.8.9/utils/DummyEmptyContract.sol                                0       0  100.00%
contracts/0.8.9/utils/PausableUntil.sol                                    31       0  100.00%
contracts/0.8.9/utils/Versioned.sol                                        11       0  100.00%
contracts/0.8.9/utils/access/AccessControl.sol                             23       0  100.00%
contracts/0.8.9/utils/access/AccessControlEnumerable.sol                    9       0  100.00%
contracts/common/utils/PausableUntil.sol                                   29       0  100.00%
contracts/testnets/sepolia/SepoliaDepositAdapter.sol                       21      21  0.00%    49-100
TOTAL                                                                    3848     115  97.01%

Diff against master

Filename                                                                Stmts    Miss  Cover
--------------------------------------------------------------------  -------  ------  --------
contracts/0.4.24/Lido.sol                                                  -7      +7  -3.41%
contracts/0.4.24/StETH.sol                                                 +7       0  +100.00%
contracts/0.8.25/Accounting.sol                                           +83      +5  +93.98%
contracts/0.8.25/interfaces/IDepositContract.sol                            0       0  +100.00%
contracts/0.8.25/interfaces/ILido.sol                                       0       0  +100.00%
contracts/0.8.25/interfaces/IOracleReportSanityChecker.sol                  0       0  +100.00%
contracts/0.8.25/interfaces/IPostTokenRebaseReceiver.sol                    0       0  +100.00%
contracts/0.8.25/interfaces/IStakingRouter.sol                              0       0  +100.00%
contracts/0.8.25/interfaces/IWithdrawalQueue.sol                            0       0  +100.00%
contracts/0.8.25/lib/GIndex.sol                                           +33     +18  +45.45%
contracts/0.8.25/lib/SSZ.sol                                              +16     +11  +31.25%
contracts/0.8.25/utils/AccessControlConfirmable.sol                       +30       0  +100.00%
contracts/0.8.25/utils/PausableUntilWithRoles.sol                          +3       0  +100.00%
contracts/0.8.25/vaults/Dashboard.sol                                     +86      +1  +98.84%
contracts/0.8.25/vaults/Delegation.sol                                    +31       0  +100.00%
contracts/0.8.25/vaults/Permissions.sol                                   +33      +1  +96.97%
contracts/0.8.25/vaults/StakingVault.sol                                 +121       0  +100.00%
contracts/0.8.25/vaults/VaultFactory.sol                                  +39       0  +100.00%
contracts/0.8.25/vaults/VaultHub.sol                                     +178     +42  +76.40%
contracts/0.8.25/vaults/interfaces/IStakingVault.sol                        0       0  +100.00%
contracts/0.8.25/vaults/predeposit_guarantee/CLProofVerifier.sol          +11       0  +100.00%
contracts/0.8.25/vaults/predeposit_guarantee/PredepositGuarantee.sol     +149       0  +100.00%
contracts/0.8.9/Burner.sol                                                 +1       0  +100.00%
contracts/0.8.9/LidoLocator.sol                                            +4       0  +100.00%
contracts/0.8.9/sanity_checks/OracleReportSanityChecker.sol               -15      +1  -0.46%
contracts/common/utils/PausableUntil.sol                                  +29       0  +100.00%
TOTAL                                                                    +832     +86  -2.03%

Results for commit: a94282b

Minimum allowed coverage is 90%

♻️ This comment has been updated with latest results

@tamtamchik tamtamchik mentioned this pull request Feb 19, 2025
Closed
tamtamchik and others added 19 commits February 27, 2025 10:36
@tamtamchik
fix: make test work again
9dd9bea
@sergeyWh1te
feat: fuzzing shareRate
2dfe89e
@sergeyWh1te
feat: fuzzing shareRate merge updates
cf4de6c
@sergeyWh1te
feat: refactoring fuzzing StakingRouter mock
6e47b45
@tamtamchik
Merge branch 'feat/vaults' into feat/vaults-fuzzing
9034fe6
@kovalgek
feat: add solvency test for staking vault
7369dfe
@kovalgek
fix: add vault connection tests
ad5a1dd
@kovalgek
fix: fix fuzz tests
66e45a0
@tamtamchik
fix: fuzzing setup
73c02da
@tamtamchik
Merge branch 'feat/vaults-fuzzing' into feat/staking-vaults-solvency-…
ac35088 
…tests
@tamtamchik
Merge branch 'feat/vaults' into feat/vaults-fuzzing
a5a94d2
@tamtamchik
chore: small refactoring
d18273c
@kovalgek
fix: small test refactoring
bcb6f2d
@kovalgek
Merge branch 'feat/staking-vaults-solvency-tests' of github.com:lidof…
8b3511d 
…inance/core into feat/staking-vaults-solvency-tests
@tamtamchik
Merge remote-tracking branch 'origin/feat/vaults' into feat/staking-v…
96e86b7 
…aults-solvency-tests
@tamtamchik
Merge branch 'feat/vaults' into feat/vaults-fuzzing
d1bc3b8
@tamtamchik
Merge branch 'feat/vaults-fuzzing' into feat/staking-vaults-solvency-…
1980510 
…tests
@tamtamchik
feat: reduce logs
db8c0b3
@tamtamchik
feat: add detailed logs
9bd545d
@tamtamchik tamtamchik requested a review from dry914 March 31, 2025 12:37
@tamtamchik tamtamchik changed the title feat: fuzzing, invariants, solvency test: fuzzing, invariants, solvency Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dry914 dry914 Awaiting requested review from dry914

Assignees
No one assigned
Labels
tests When it comes to testing the code vaults
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tamtamchik @sergeyWh1te @kovalgek