Skip to content

Conversation

@eenti
Copy link
Contributor

@eenti eenti commented May 21, 2025

Please, go through these steps before you request a review:

📝 Describe your changes

  1. Added a link to the new "Run on Lido" section at the introduction page, so folks can access it from there.
  2. Created a "Run on Lido" section with Docusaurus' multi-instance feature.
  3. Inside "Run on Lido" we added a complete CSM Guide with multiple integration guides, key generation and more.

🔎 Include source of truth for all changes that reference on-chain data (addresses, etc.)

Only references to onchain addresses are to the Lido Execution Layer and Withdrawal Vaults, of both Mainnet and Hoodi.

@eenti eenti requested a review from a team as a code owner May 21, 2025 18:54
Copy link
Contributor

@dgusakov dgusakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to trink about what stuff from http://localhost:3000/staking-modules/csm/guides/ should be moved (to avoid duplicates) and how this new guide will be linked from that section

@dgusakov
Copy link
Contributor

Also review build errors and fix them

@eenti
Copy link
Contributor Author

eenti commented May 22, 2025

We need to trink about what stuff from http://localhost:3000/staking-modules/csm/guides/ should be moved (to avoid duplicates) and how this new guide will be linked from that section

This first one does not include anything repeated from the main guides. In fact some of them are referenced and linked, but I agree. We can discuss later and move some of them.

@eenti
Copy link
Contributor Author

eenti commented May 22, 2025

Reverted package.json and fixed build errors. Please check again @dgusakov.

eenti and others added 2 commits June 19, 2025 15:32
Standarized screenshots
dgusakov
dgusakov previously approved these changes Jun 26, 2025
dgusakov
dgusakov previously approved these changes Jun 26, 2025
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR contains broken links, please resolve the issues according to the build report.

@eenti eenti requested a review from TheDZhon July 2, 2025 23:31
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheDZhon TheDZhon merged commit a9cb00e into lidofinance:main Jul 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants