Hermes 1335 parity#67
Merged
Merged
Conversation
- STATUSES gains 'scheduled' between 'todo' and 'ready' (upstream e3823657d). Column renders with muted tint to read as parked/delayed vs blocked (warning) or running (success). - Task type / SELECT add schema-tolerant reads for branch_name (1733cb3a1), model_override (79f6654d1/f01ee0b57), session_id (31fe22903), and last_heartbeat_at (used by stale detection in e286e6875). All four are NULL-fallback on prior-version DBs. - SidePane renders Branch, Model, Session rows when populated, and Heartbeat (ago format) only for running tasks with a recent beat. Workspace stays adjacent to Branch so worktree+branch read together. - unblock() handles both 'blocked' and 'scheduled' per upstream unblock_task semantics; 'u' shortcut and the 'Unblock' action surface for either state. editStatus picker gains a 'scheduled' transition via the new `hermes kanban schedule` verb. - Tests: new "scheduled status + new fields parity" block seeds a board exercising every new column and asserts boardOf/SidePane render. Pre-existing nav tests adjusted to account for the extra column. Skipped (per task scope): drag/drop affordances, worker visibility endpoints (02efad704 — herm doesn't have a corresponding interaction pattern), filter-by-run-outcome (341912c22 — orthogonal to current filter chip model).
Strip ANSI escape sequences (CSI, OSC, DCS, SOS, PM, APC, dangling introducers) and C0/C1 control bytes from gateway-, provider-, and tool-sourced strings at the reducer chokepoint. OpenTUI's <text> renders these as literal cells or, worse, lets the terminal interpret mouse-mode/cursor escapes that leaked through tool output. New helper src/utils/sanitize.ts is applied at every wire boundary in turnReducer (system/error/interrupt text, message delta + complete, tool start/progress/complete preview+result+summary+inline_diff, thinking, subagent start/tool/complete/progress, transcript hydration). DiffBlock and DiffTabs swap their per-file ad-hoc SGR regexes for the shared helper so there is one place to update the byte vocabulary. Composer input is untouched (per task constraint). 15 new tests in test/sanitize.test.tsx cover dangling CSI, SGR color, OSC (BEL- and ST-terminated + unterminated), DCS/APC sixel-style, C0 keep-tab/LF/CR, C1+DEL, plus reducer-level coverage of every entry point and a Tool/MessageList render-frame assertion that no control bytes leak into the rendered cells.
Contributor
|
🎉 This PR is included in version 1.6.1-dev.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Merged
Contributor
|
🎉 This PR is included in version 1.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1335ce996, including new auxiliary, compression, Discord, and Kanban config keys.Test Plan
bunx tsc --noEmitbun testbun run build