This repository was archived by the owner on Jan 26, 2023. It is now read-only.
Call Tendermint client to retrieve transaction results when converting from Tendermint block to Many block #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g from Tendermint block to Many block
…nto transaction-results
Codecov Report
@@ Coverage Diff @@
## main #307 +/- ##
==========================================
- Coverage 76.01% 75.90% -0.11%
==========================================
Files 68 68
Lines 9371 9384 +13
==========================================
Hits 7123 7123
- Misses 2248 2261 +13
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hansl
suggested changes
Jan 5, 2023
Contributor
hansl
left a comment
hansl
left a comment
There was a problem hiding this comment.
Neat. Can you add a test to make sure this works and that we won't break it later?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second attempt at adding transaction results to the Many blocks that are constructed from tendermint blocks in the abci module.