Skip to content

feat: allow encrypted secrets file syntax for checksum updates #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+29 −4
Draft

feat: allow encrypted secrets file syntax for checksum updates #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40ef12e
feat: allow encrypted secrets file syntax for checksum updates
CharlieDixon Mar 11, 2025
92b7aa9
Bump chart version
CharlieDixon Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/lightdash/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 1.5.5
version: 1.5.6

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
2 changes: 1 addition & 1 deletion charts/lightdash/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,4 +140,4 @@ If you don't want helm to manage this, you may wish to separately create a secre
| tolerations | list | `[]` | |

----------------------------------------------
Autogenerated from chart metadata using [helm-docs v1.7.0](https://github.com/norwoodj/helm-docs/releases/v1.7.0)
Autogenerated from chart metadata using [helm-docs v1.14.2](https://github.com/norwoodj/helm-docs/releases/v1.14.2)
25 changes: 25 additions & 0 deletions charts/lightdash/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,3 +157,28 @@ We truncate at 63 chars because some Kubernetes name fields are limited to this
{{- define "lightdash.headlessBrowser.port" -}}
{{- printf ((index .Values "browserless-chrome").service.port | toString) -}}
{{- end -}}


{{/*
Generate checksum using both standard and encrypted secret file types
Usage: {{ include "checksums.secrets" . }}
*/}}
{{- define "checksums.secrets" -}}
{{- $files := list -}}
{{- $path := $.Template.BasePath -}}

{{/* Add standard secrets */}}
{{- $files = append $files (print $path "/secrets.yaml") -}}

{{/* Add encrypted secret files if they exist */}}
{{- $encryptedFiles := concat (.Files.Glob "*secrets.yaml.encrypted") (.Files.Glob "*secrets.enc.yaml") -}}
{{- if $encryptedFiles -}}
{{- range $encryptedFiles -}}
{{- $files = append $files . -}}
{{- end -}}
{{- end -}}

{{/* Generate combined checksum from secret file(s) */}}
{{- range $files }}
{{- include . $ | sha256sum -}}
{{- end -}}
2 changes: 1 addition & 1 deletion charts/lightdash/templates/backendDeployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ spec:
{{- toYaml . | nindent 8 }}
{{- end }}
checksum/config: {{ include (print $.Template.BasePath "/configmap.yaml") . | sha256sum }}
checksum/secrets: {{ include (print $.Template.BasePath "/secrets.yaml") . | sha256sum }}
checksum/secrets: {{ include "checksums.secrets" . }}
labels:
{{- include "lightdash.selectorLabels" . | nindent 8 }}
app.kubernetes.io/component: backend
Expand Down
2 changes: 1 addition & 1 deletion charts/lightdash/templates/workerDeployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ spec:
{{- toYaml . | nindent 8 }}
{{- end }}
checksum/config: {{ include (print $.Template.BasePath "/configmap.yaml") . | sha256sum }}
checksum/secrets: {{ include (print $.Template.BasePath "/secrets.yaml") . | sha256sum }}
checksum/secrets: {{ include "checksums.secrets" . }}
labels:
{{- include "lightdash.selectorLabels" . | nindent 8 }}
app.kubernetes.io/component: worker
Expand Down