update your code #135
Open
update your code #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samglish
commented
Jun 6, 2025
There was a problem hiding this comment.
Web Standards and Accessibility
| Before | After |
|---|---|
No lang attribute |
Added lang="fr" to specify the content language (French) |
| No character encoding | Added <meta charset="UTF-8"> to properly display special characters |
| Not mobile-friendly | Added <meta name="viewport"> for responsive design |
Visual Presentation (CSS Styling)
| Before | After |
|---|---|
Only font-size defined |
Added modern font, background color, text color, padding, and spacing |
| Plain list | Bold city names and proper spacing between items |
| Unstyled links | Colored links with hover effect |
Content Quality
| Before | After |
|---|---|
| Only 4 cities listed | Extended to 8 major cities |
| Hard-to-read numbers | Formatted numbers using non-breaking spaces (e.g. 17 836 133) |
| Content in English | Translated fully into French to match lang="fr" |
External Link Best Practices
| Before | After |
|---|---|
| Just a basic link | Added target="_blank" to open in a new tab |
| — | Added rel="noopener noreferrer" for security and performance |
Professional HTML Structure
- Clean indentation
- Proper semantic tags:
<h1>,<ol>,<li>,<strong> - Organized internal CSS
- Full, valid HTML5 structure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Web Standards and Accessibility
langattributelang="fr"to specify the content language (French)<meta charset="UTF-8">to properly display special characters<meta name="viewport">for responsive designVisual Presentation (CSS Styling)
font-sizedefinedContent Quality
17 836 133)lang="fr"External Link Best Practices
target="_blank"to open in a new tabrel="noopener noreferrer"for security and performanceProfessional HTML Structure
<h1>,<ol>,<li>,<strong>