Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add destroy method #21

Merged
merged 1 commit into from
Feb 14, 2025
Merged

add destroy method #21

merged 1 commit into from
Feb 14, 2025

Conversation

benjaminstary
Copy link
Contributor

Pridávam destroy metodu. Unmountujem komponent a zaroven rendrujem placeholder aby neskakal obsah.

@benjaminstary benjaminstary self-assigned this Feb 13, 2025
Copy link

vercel bot commented Feb 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
daypickr ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 1:51pm

Copy link
Contributor

@jurajk jurajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

toto ale bude fungovat len v reacte, ktory v oranzi nikto nepouziva, ci?

zaroven, placeholder by som zaradil pod datepicker, takto znie genericky, ale je to input s kalendarom...

@benjaminstary
Copy link
Contributor Author

Use case je taký, že ked zavolaju window.ODS.destroyModulesWithin(document) tak sa nič neudeje, pretože DatePickr nemal doteraz destroy(). Pridal som teda tento unmount, ktorý odstráni všetko po zavolaní this.instance.destroy() v statick skriptoch v ODS. Zároveň ale nechcene aby bol celý element aj s HTMLkom odstránený, pretože pri volani window.ODS.initModulesWithin(document) poskoci obsah. Preto tento placeholder, ktory zastúpi miesto, a userovi nebude skakat obsah.

Im sa totiz dialo ze ked zavolali destroy a potom reinitli, tak sa Datepicker inicializoval dvakrat a ziskal focus a usera scrollovalo

@jurajk
Copy link
Contributor

jurajk commented Feb 14, 2025

Use case je taký, že ked zavolaju window.ODS.destroyModulesWithin(document) tak sa nič neudeje, pretože DatePickr nemal doteraz destroy(). Pridal som teda tento unmount, ktorý odstráni všetko po zavolaní this.instance.destroy() v statick skriptoch v ODS. Zároveň ale nechcene aby bol celý element aj s HTMLkom odstránený, pretože pri volani window.ODS.initModulesWithin(document) poskoci obsah. Preto tento placeholder, ktory zastúpi miesto, a userovi nebude skakat obsah.

Im sa totiz dialo ze ked zavolali destroy a potom reinitli, tak sa Datepicker inicializoval dvakrat a ziskal focus a usera scrollovalo

prepac ja som si neuvedomil ze sme v daypickr repozitari a nie v ODS. potom dobre, nic som nepovedal. idem zistit ako to releasnut :)

@jurajk jurajk merged commit 36ca932 into main Feb 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants