Add MMCR Loss #1446
Merged
Add MMCR Loss #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsutor
force-pushed
the
maximum_manifold_capacity
branch
from
d116654 to
5e95fc5
Compare
Add MMCR Transform (as subclass of MultiViewTransform)
johnsutor
force-pushed
the
maximum_manifold_capacity
branch
from
5e95fc5 to
a22fd68
Compare
|
Hi @johnsutor, thank you for your contribution! We'll have someone from the team review the pull-request asap. |
guarin
reviewed
Dec 11, 2023
guarin
reviewed
Dec 11, 2023
Co-authored-by: guarin <[email protected]>
Co-authored-by: guarin <[email protected]>
… from paper) Format code and fix imports in MMCR transform file
guarin
reviewed
Dec 12, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1446 +/- ##
==========================================
+ Coverage 85.24% 85.34% +0.09%
==========================================
Files 130 132 +2
Lines 5517 5547 +30
==========================================
+ Hits 4703 4734 +31
+ Misses 814 813 -1 ☔ View full report in Codecov by Sentry. |
guarin
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses #1423, implementing the Maximum Manifold Capacity loss and transforms. The default parameters are set to those used for ImageNet in the original paper https://arxiv.org/pdf/2303.03307.pdf