Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VICRegLoss (remove extra de-mean) #1450

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

philippmwirth
Copy link
Contributor

Fix VICRegLoss (remove extra de-mean)

Closes #1445.

  • Remove extra de-mean.
  • The loss doesn't change according to our regression test.

Copy link
Contributor

@guarin guarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (66ad1b4) 85.24% compared to head (3040372) 85.34%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1450      +/-   ##
==========================================
+ Coverage   85.24%   85.34%   +0.09%     
==========================================
  Files         130      132       +2     
  Lines        5517     5547      +30     
==========================================
+ Hits         4703     4734      +31     
+ Misses        814      813       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippmwirth philippmwirth merged commit 7cf2970 into master Dec 13, 2023
10 checks passed
@philippmwirth philippmwirth deleted the philipp-fix-vicreg-loss-de-mean branch December 13, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VICReg Loss De-Means Twice?
2 participants