Make KNN feature normalization optional #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1457 +/- ##
==========================================
+ Coverage 85.34% 85.37% +0.02%
==========================================
Files 133 133
Lines 5563 5572 +9
==========================================
+ Hits 4748 4757 +9
Misses 815 815 ☔ View full report in Codecov by Sentry. |
guarin
commented
Dec 15, 2023
philippmwirth
approved these changes
Dec 18, 2023
guarin
added a commit
that referenced
this pull request
Jan 19, 2024
* Make KNN feature normalization optional * Reset features after training epoch * Always convert features to correct dtype
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
How was it tested?
Closes: #1425