Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codecov config #1472

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Add codecov config #1472

merged 1 commit into from
Jan 11, 2024

Conversation

IgorSusmelj
Copy link
Contributor

Changes

  • Added a codecov.yml config file to make codecov pass even if the coverage slightly goes down by 0.5% as recommended. This will allow us to enforce again that all tests have to pass in order to merge a PR (we disabled this as codecov got annoying)

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (deb3c31) 85.50% compared to head (934f20d) 85.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1472   +/-   ##
=======================================
  Coverage   85.50%   85.50%           
=======================================
  Files         135      135           
  Lines        5657     5657           
=======================================
  Hits         4837     4837           
  Misses        820      820           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@guarin guarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Are you sure this are the only required fields?

@IgorSusmelj IgorSusmelj merged commit 2b215aa into master Jan 11, 2024
10 checks passed
@IgorSusmelj IgorSusmelj deleted the make_code_coverage_less_strict_is branch January 11, 2024 15:11
guarin pushed a commit that referenced this pull request Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants