Update install dependencies #1476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1476 +/- ##
=======================================
Coverage 85.50% 85.50%
=======================================
Files 135 135
Lines 5657 5657
=======================================
Hits 4837 4837
Misses 820 820 ☔ View full report in Codecov by Sentry. |
guarin
reviewed
Jan 15, 2024
guarin
approved these changes
Jan 16, 2024
| - name: Install Minimal Dependencies | ||
| run: pip install -r requirements/minimal_requirements.txt | ||
| - name: Install Package Without Dependencies | ||
| run: pip install --no-deps . | ||
| - name: Run Tests | ||
| run: python -m pytest -s -v --runslow | ||
| run: | | ||
| export LIGHTLY_SERVER_LOCATION="localhost:-1" |
There was a problem hiding this comment.
We use it in the other test as well. To make sure we can run all tests offline and don't require the lightly api online.
guarin
pushed a commit
that referenced
this pull request
Jan 19, 2024
* remove openapi.txt requirements file * Add pydantic and aenum to base.txt dependencies * Add minimal dependencies requirements file * Add test for minimal dependency * Update readme and other docs to make it clear users need Python 3.7 to use lightly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This allows to install the lightly package with minimal dependencies (no PyTorch and torchvision)
New minimal dependencies (to run all the unittests) are the following: