-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typecheck SwAV loss #1759
Typecheck SwAV loss #1759
Conversation
…wav-loss
…wav-loss
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1759 +/- ##
=======================================
Coverage 85.24% 85.24%
=======================================
Files 162 162
Lines 6735 6736 +1
=======================================
+ Hits 5741 5742 +1
Misses 994 994 ☔ View full report in Codecov by Sentry. |
38e8adf
to
f400be5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would definitely use the new typing syntax wherever possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Typecheck SwAV loss