Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typecheck SwAV loss #1759

Merged
merged 8 commits into from
Dec 27, 2024
Merged

Typecheck SwAV loss #1759

merged 8 commits into from
Dec 27, 2024

Conversation

philippmwirth
Copy link
Contributor

Typecheck SwAV loss

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.24%. Comparing base (066bd70) to head (a7eb3ab).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1759   +/-   ##
=======================================
  Coverage   85.24%   85.24%           
=======================================
  Files         162      162           
  Lines        6735     6736    +1     
=======================================
+ Hits         5741     5742    +1     
  Misses        994      994           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippmwirth philippmwirth force-pushed the philipp-type-check-swav-loss branch from 38e8adf to f400be5 Compare December 27, 2024 14:07
Copy link
Contributor

@MalteEbner MalteEbner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would definitely use the new typing syntax wherever possible.

Base automatically changed from philipp-type-check-pmsn-loss to master December 27, 2024 14:43
philippmwirth and others added 2 commits December 27, 2024 15:58
Copy link
Contributor

@MalteEbner MalteEbner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philippmwirth philippmwirth merged commit 64d3d3a into master Dec 27, 2024
14 checks passed
@philippmwirth philippmwirth deleted the philipp-type-check-swav-loss branch December 27, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants